Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map missing fields in opportunity #27904

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

pateljannat
Copy link
Contributor

Issue:

  1. When we create an Opportunity from Lead manually, the Opportunity picks the value of similar fields from Lead doctype.
  2. The same does not happen when Opportunity is created from Lead using data import.

Fix:

  1. Added logic on the server-side, which checks if a field in opportunity does not have a value and this field is present in Lead/Customer doctype then fetch that value and add it to the field in Opportunity.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #27904 (1988f20) into develop (2b9b158) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #27904      +/-   ##
===========================================
- Coverage    54.44%   54.35%   -0.10%     
===========================================
  Files         1254     1254              
  Lines        67750    67759       +9     
===========================================
- Hits         36885    36828      -57     
- Misses       30865    30931      +66     
Impacted Files Coverage Δ
erpnext/crm/doctype/opportunity/opportunity.py 72.27% <100.00%> (+1.29%) ⬆️
...eport/item_variant_details/item_variant_details.py 32.14% <0.00%> (-52.39%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 69.49% <0.00%> (-22.04%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
erpnext/stock/reorder_item.py 76.27% <0.00%> (-0.85%) ⬇️
... and 15 more

@ruchamahabal ruchamahabal self-assigned this Oct 18, 2021
@ruchamahabal ruchamahabal merged commit d81f811 into frappe:develop Oct 20, 2021
@pateljannat
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix

@pateljannat
Copy link
Contributor Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-13-hotfix

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 20, 2021
(cherry picked from commit d81f811)

# Conflicts:
#	erpnext/crm/doctype/opportunity/opportunity.py
mergify bot pushed a commit that referenced this pull request Oct 20, 2021
(cherry picked from commit d81f811)

# Conflicts:
#	erpnext/crm/doctype/opportunity/opportunity.py
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2021

backport version-13-pre-release

✅ Backports have been created

pateljannat added a commit that referenced this pull request Oct 20, 2021
…-27904

fix: map missing fields in opportunity (backport #27904)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
(cherry picked from commit d81f811)

# Conflicts:
#	erpnext/crm/doctype/opportunity/opportunity.py
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-27904

fix: map missing fields in opportunity (backport frappe#27904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants