Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HSN based tax breakup table check in GST Settings #27907

Merged

Conversation

nemesis189
Copy link
Contributor

@nemesis189 nemesis189 commented Oct 11, 2021

Due to changes introduced by this PR, Tax Breakup table was displaying tax based only on items instead of HSN Code.


This feat adds a check in the GST Settings page that lets you choose HSN wise breakup or Item wise breakup.
Created a new section GST Tax Settings for the Round Off check and Tax Breakup check.

Item wise tax breakup
HSN wise tax breakup

In the above example, 2 items had same HSN code so they were grouped together in the HSN wise breakup table.

GST Settings page before changes

no-docs

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #27907 (fc4facc) into develop (7acdcc7) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@             Coverage Diff             @@
##           develop   #27907      +/-   ##
===========================================
- Coverage    54.43%   54.41%   -0.02%     
===========================================
  Files         1254     1254              
  Lines        67717    67722       +5     
===========================================
- Hits         36861    36852       -9     
- Misses       30856    30870      +14     
Impacted Files Coverage Δ
erpnext/regional/india/utils.py 65.85% <88.88%> (+0.12%) ⬆️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/portal/product_configurator/utils.py 33.06% <0.00%> (-0.41%) ⬇️
erpnext/stock/reorder_item.py 76.27% <0.00%> (ø)
erpnext/stock/stock_ledger.py 86.12% <0.00%> (+0.18%) ⬆️
erpnext/accounts/utils.py 59.38% <0.00%> (+0.18%) ⬆️
... and 12 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

Command backport version-13-hotfix: pending

backport version-13-hotfix is pending

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2021

Command backport version-13-hotfix: success

Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 13, 2021
…-27907

feat: HSN based tax breakup table check in GST Settings  (backport #27907)
@jigneshpshah
Copy link
Contributor

Hi @nemesis189 , Till this feature is merged on version 13 (production )branch, do you have any workaround, as all our clients in FC are facing this issue after upgrade to v13.12.1

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…x-breakup

feat: HSN based tax breakup table check in GST Settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants