Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TDS round off not working from second transaction #27934

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 13, 2021

Tax Withholding Round Off amount check was done only in the code block where the TDS for the very first transaction was calculated.

So for the subsequent transactions let's say second and so on the TDS amount was not getting rounded to the nearest integer

Moved the check to the code block where the final tax amount is returned so that the tax amount is rounded off for all types (TDS and TCS both) and all transactions

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #27934 (b7a0853) into develop (6019f60) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #27934      +/-   ##
===========================================
- Coverage    54.55%   54.42%   -0.14%     
===========================================
  Files         1248     1255       +7     
  Lines        67518    67817     +299     
===========================================
+ Hits         36836    36907      +71     
- Misses       30682    30910     +228     
Impacted Files Coverage Δ
...x_withholding_category/tax_withholding_category.py 85.78% <100.00%> (ø)
...ctype/product_tax_category/product_tax_category.py 0.00% <0.00%> (-100.00%) ⬇️
...rations/doctype/taxjar_settings/taxjar_settings.py 29.50% <0.00%> (-70.50%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
erpnext/shopping_cart/utils.py 32.14% <0.00%> (-3.58%) ⬇️
...vs_serial_no_count/stock_qty_vs_serial_no_count.py 93.10% <0.00%> (-3.45%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.55% <0.00%> (-2.95%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
... and 40 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2021

backport version-13-hotfix

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2021

backport version-13-pre-release

🟠 Waiting for conditions

  • merged [:pushpin: backport requirement]

@deepeshgarg007 deepeshgarg007 merged commit 46e8009 into frappe:develop Oct 18, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-hotfix

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-pre-release

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 18, 2021
…-27934

fix: TDS round off not working from second transaction (backport #27934)
deepeshgarg007 added a commit that referenced this pull request Oct 18, 2021
…se/pr-27934

fix: TDS round off not working from second transaction (backport #27934)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-27934

fix: TDS round off not working from second transaction (backport frappe#27934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant