Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error message for Serial No mismatch between SI and DN #27947

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

marination
Copy link
Collaborator

Issue:
Screenshot 2021-10-13 at 4 39 25 PM

Fix:
Screenshot 2021-10-13 at 4 37 37 PM

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #27947 (60f35ad) into develop (c6a56a8) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff            @@
##           develop   #27947   +/-   ##
========================================
  Coverage    54.39%   54.40%           
========================================
  Files         1254     1255    +1     
  Lines        67725    67814   +89     
========================================
+ Hits         36839    36894   +55     
- Misses       30886    30920   +34     
Impacted Files Coverage Δ
...xt/accounts/doctype/sales_invoice/sales_invoice.py 76.50% <25.00%> (-0.17%) ⬇️
...ctype/product_tax_category/product_tax_category.py 0.00% <0.00%> (-100.00%) ⬇️
...rations/doctype/taxjar_settings/taxjar_settings.py 29.50% <0.00%> (-70.50%) ⬇️
erpnext/shopping_cart/utils.py 32.14% <0.00%> (-3.58%) ⬇️
erpnext/stock/stock_ledger.py 85.53% <0.00%> (-1.86%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
erpnext/erpnext_integrations/taxjar_integration.py 18.75% <0.00%> (-0.89%) ⬇️
...k/doctype/stock_ledger_entry/stock_ledger_entry.py 85.21% <0.00%> (-0.75%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.90% <0.00%> (-0.44%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 69.67% <0.00%> (ø)
... and 21 more

@marination marination merged commit ee25ba0 into frappe:develop Oct 14, 2021
@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

Command backport version-13-hotfix: success

Backports have been created

marination added a commit that referenced this pull request Oct 14, 2021
…-27947

fix: Improve error message for Serial No mismatch between SI and DN (backport #27947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant