Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: value_after_depreciation calculation #27954

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Oct 14, 2021

Fixes #27431

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #27954 (9bb0f5a) into develop (9043812) will increase coverage by 0.00%.
The diff coverage is 30.00%.

❗ Current head 9bb0f5a differs from pull request most recent head 45cc988. Consider uploading reports for the commit 45cc988 to get more accurate results

@@           Coverage Diff            @@
##           develop   #27954   +/-   ##
========================================
  Coverage    54.35%   54.36%           
========================================
  Files         1255     1255           
  Lines        67809    67814    +5     
========================================
+ Hits         36860    36866    +6     
+ Misses       30949    30948    -1     
Impacted Files Coverage Δ
erpnext/hr/doctype/shift_type/shift_type.py 21.51% <0.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 76.50% <25.00%> (-0.26%) ⬇️
erpnext/assets/doctype/asset/asset.py 71.60% <100.00%> (ø)
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/accounts/deferred_revenue.py 75.22% <0.00%> (-0.89%) ⬇️
erpnext/stock/reorder_item.py 76.27% <0.00%> (-0.85%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 76.39% <0.00%> (-0.38%) ⬇️
erpnext/projects/doctype/project/project.py 53.90% <0.00%> (-0.36%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.86% <0.00%> (-0.24%) ⬇️
... and 9 more

@nextchamp-saqib nextchamp-saqib merged commit 1f70dd6 into frappe:develop Oct 14, 2021
@nextchamp-saqib
Copy link
Member Author

@Mergifyio backport version-13-hotfix

mergify bot pushed a commit that referenced this pull request Oct 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

Command backport version-13-hotfix: success

Backports have been created

rohitwaghchaure added a commit that referenced this pull request Oct 14, 2021
…-27954

fix: value_after_depreciation calculation (backport #27954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating existing, partially depreciated assets with correct depreciation is impossible
1 participant