-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Retain space inside Serial no string while cleaning serial nos #27962
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #27962 +/- ##
===========================================
+ Coverage 54.38% 54.43% +0.05%
===========================================
Files 1255 1255
Lines 67814 67817 +3
===========================================
+ Hits 36879 36918 +39
+ Misses 30935 30899 -36
|
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
f442e2d
to
a934167
Compare
@Mergifyio backport version-13-hotfix |
Command
|
…-27962 fix: Retain space inside Serial no string while cleaning serial nos (backport #27962)
@Mergifyio backport version-13-pre-release |
✅ Backports have been created
|
…se/pr-27962 fix: Retain space inside Serial no string while cleaning serial nos (backport #27962)
…fix/pr-27962 fix: Retain space inside Serial no string while cleaning serial nos (backport frappe#27962)
A missing case #26596 did not consider
Issue:
SN - 123 - 2021\n SN - 124 - 2021\n
SN - 123 - 2021
with spaces in it. The previous fix removed all spaces in the string. SoSN - 123 - 2021\n
becomesSN-123-2021\n
Fix:
SN - 123 - 2021\n SN - 124 - 2021\n
is cleaned to becomeSN - 123 - 2021\nSN - 124 - 2021\n
without trailing and leading spaces i.e. spaces surrounding the serial no removed