Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retain space inside Serial no string while cleaning serial nos #27962

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

marination
Copy link
Collaborator

@marination marination commented Oct 14, 2021

A missing case #26596 did not consider

Issue:

  • Consider Serial No string SN - 123 - 2021\n SN - 124 - 2021\n
  • The individual serial no is SN - 123 - 2021 with spaces in it. The previous fix removed all spaces in the string. So
    SN - 123 - 2021\n becomes SN-123-2021\n
  • This caused serial no mismatch issues in some sales invoices created from legacy delivery notes

Fix:

  • String SN - 123 - 2021\n SN - 124 - 2021\n is cleaned to become SN - 123 - 2021\nSN - 124 - 2021\n without trailing and leading spaces i.e. spaces surrounding the serial no removed

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #27962 (41035b0) into develop (230a5d4) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 41035b0 differs from pull request most recent head f442e2d. Consider uploading reports for the commit f442e2d to get more accurate results

@@             Coverage Diff             @@
##           develop   #27962      +/-   ##
===========================================
+ Coverage    54.38%   54.43%   +0.05%     
===========================================
  Files         1255     1255              
  Lines        67814    67817       +3     
===========================================
+ Hits         36879    36918      +39     
+ Misses       30935    30899      -36     
Impacted Files Coverage Δ
erpnext/assets/doctype/asset/asset.py 71.60% <100.00%> (ø)
erpnext/controllers/stock_controller.py 90.76% <100.00%> (+0.07%) ⬆️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 80.00% <0.00%> (-0.84%) ⬇️
erpnext/stock/get_item_details.py 79.53% <0.00%> (-0.31%) ⬇️
erpnext/stock/stock_ledger.py 85.71% <0.00%> (-0.19%) ⬇️
erpnext/stock/reorder_item.py 77.11% <0.00%> (ø)
...stock/doctype/purchase_receipt/purchase_receipt.py 90.61% <0.00%> (ø)
... and 12 more

@marination marination merged commit c0e6328 into frappe:develop Oct 14, 2021
@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2021

Command backport version-13-hotfix: success

Backports have been created

marination added a commit that referenced this pull request Oct 14, 2021
…-27962

fix: Retain space inside Serial no string while cleaning serial nos (backport #27962)
@ankush
Copy link
Member

ankush commented Oct 18, 2021

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2021

backport version-13-pre-release

✅ Backports have been created

ankush added a commit that referenced this pull request Oct 18, 2021
…se/pr-27962

fix: Retain space inside Serial no string while cleaning serial nos (backport #27962)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-27962

fix: Retain space inside Serial no string while cleaning serial nos (backport frappe#27962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants