perf(minor): general ledger report #27987

nextchamp-saqib · 2021-10-18T05:27:09Z

get_totals_dict was called a no. of times, based on no. of GL Entry fetched.

Profiled Output

gle_map values are also updated even if they are not being used later on, in the case of Group by Voucher (Consolidated)

Profiled Output

Before - Called 1525242 times

After - Called 785668 times

codecov · 2021-10-18T05:49:09Z

Codecov Report

Merging #27987 (722d127) into develop (2f00469) will increase coverage by 0.07%.
The diff coverage is 11.53%.

@@             Coverage Diff             @@
##           develop   #27987      +/-   ##
===========================================
+ Coverage    55.14%   55.21%   +0.07%     
===========================================
  Files         1119     1119              
  Lines        66538    66548      +10     
===========================================
+ Hits         36693    36746      +53     
+ Misses       29845    29802      -43

Impacted Files	Coverage Δ
...t/accounts/report/general_ledger/general_ledger.py	`20.94% <11.53%> (-0.04%)`	⬇️
...value/warehouse_wise_item_balance_age_and_value.py	`92.40% <0.00%> (-2.54%)`	⬇️
erpnext/portal/utils.py	`28.98% <0.00%> (-1.45%)`	⬇️
erpnext/support/doctype/issue/issue.py	`63.41% <0.00%> (-0.98%)`	⬇️
erpnext/accounts/deferred_revenue.py	`75.11% <0.00%> (-0.89%)`	⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py	`90.51% <0.00%> (-0.73%)`	⬇️
...ice_creation_tool/opening_invoice_creation_tool.py	`60.13% <0.00%> (-0.70%)`	⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py	`70.79% <0.00%> (-0.24%)`	⬇️
erpnext/stock/stock_ledger.py	`85.09% <0.00%> (-0.19%)`	⬇️
.../report/stock_projected_qty/stock_projected_qty.py	`88.15% <0.00%> (ø)`
... and 19 more

…ptimization

szufisher · 2021-10-22T03:27:47Z

back port to v13?

…ptimization

nextchamp-saqib · 2021-11-11T08:25:34Z

@Mergifyio backport version-13-hofix

mergify · 2021-11-11T08:25:54Z

backport version-13-hofix

❌ No backport have been created

Backport to branch version-13-hofix failed: Branch not found

nextchamp-saqib · 2021-11-11T15:02:06Z

@Mergifyio backport version-13-hotfix

(cherry picked from commit ecbe4b1) # Conflicts: # erpnext/accounts/report/general_ledger/general_ledger.py

mergify · 2021-11-11T15:03:30Z

backport version-13-hotfix

✅ Backports have been created

#28355 perf(minor): general ledger report (backport #27987) has been created for branch version-13-hotfix

* perf(minor): general ledger report (backport frappe#27987) * fix: replaced "=" with "in" for multiple statuses in query (backport frappe#28193) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't make naming series mandatory for items (backport frappe#28394) * fix: Work order creation from sales order (backport frappe#28388) * fix: currency wise pricing rule not working (cherry picked from commit 43aeb54) * fix: remove item-item group name validation (backport frappe#28392) * fix: Default party account getting overriden in invoices (cherry picked from commit 8864857) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * fix: Dispatch address details not displayed in v13 * fix: Unable to edit supplier scorecard criteria name once created (backport frappe#28348) * fix: performance to submit the JV (cherry picked from commit 7472760) * fix: Pricing Rule not created against the Promotional Scheme (cherry picked from commit d82910b) * fix: sum of components in salary register (backport frappe#28237) * fix: auto update price list rate * fix: Pull Items that are in JC in Stock Entry against JC - Check if items pulled in stock entry are present in Job Card - Code cleanup and removed redundant checks Co-authored-by: Gavin D'souza <gavin18d@gmail.com> (cherry picked from commit 3da0302) * test: Stock Entry from JC correctness (items mapping and qty) (cherry picked from commit 0aa237f) * fix: Partial Trabsfers against JC - Fixed transferred qty not back updating on JC if partial transfer - Partial transfer not mapping pending qty from JC correctly in SE - tests for above cases - minor code cleanup (cherry picked from commit e8d0c25) * fix: (travis) Production Plan Summary Report breaks if no WO - `get_cached_value` throws a DoesNotExistError if non-existent value, used `get_value` instead - accomodate production plan items that dont have WO/PO against them as well (blank values) - added some None value handling to avoid AttributeError (cherry picked from commit 1eb3ca2) * fix: Server side test - make `tests_that_skip_setup` a tuple (added comma) - remove manual teardown in `test_job_card_material_transfer_correctness` to avoid premature committing - transfer_material_against = "Job Card" while making BOM with mulitple operations (cherry picked from commit bb561ba) * fix: `test_job_card_partial_material_transfer` test - Use a specific BOM for JC tests - Utility to create said BOM - Sider: unused variable (cherry picked from commit a5f8274) Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com>

* perf(minor): general ledger report (backport frappe#27987) * fix: replaced "=" with "in" for multiple statuses in query (backport frappe#28193) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't make naming series mandatory for items (backport frappe#28394) * fix: Work order creation from sales order (backport frappe#28388) * fix: currency wise pricing rule not working (cherry picked from commit 43aeb54) * fix: remove item-item group name validation (backport frappe#28392) * fix: Default party account getting overriden in invoices (cherry picked from commit 8864857) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * fix: Dispatch address details not displayed in v13 * fix: Unable to edit supplier scorecard criteria name once created (backport frappe#28348) * fix: performance to submit the JV (cherry picked from commit 7472760) * fix: Pricing Rule not created against the Promotional Scheme (cherry picked from commit d82910b) * fix: sum of components in salary register (backport frappe#28237) * fix: auto update price list rate * fix: Pull Items that are in JC in Stock Entry against JC - Check if items pulled in stock entry are present in Job Card - Code cleanup and removed redundant checks Co-authored-by: Gavin D'souza <gavin18d@gmail.com> (cherry picked from commit 3da0302) * test: Stock Entry from JC correctness (items mapping and qty) (cherry picked from commit 0aa237f) * fix: Partial Trabsfers against JC - Fixed transferred qty not back updating on JC if partial transfer - Partial transfer not mapping pending qty from JC correctly in SE - tests for above cases - minor code cleanup (cherry picked from commit e8d0c25) * fix: (travis) Production Plan Summary Report breaks if no WO - `get_cached_value` throws a DoesNotExistError if non-existent value, used `get_value` instead - accomodate production plan items that dont have WO/PO against them as well (blank values) - added some None value handling to avoid AttributeError (cherry picked from commit 1eb3ca2) * fix: Server side test - make `tests_that_skip_setup` a tuple (added comma) - remove manual teardown in `test_job_card_material_transfer_correctness` to avoid premature committing - transfer_material_against = "Job Card" while making BOM with mulitple operations (cherry picked from commit bb561ba) * fix: `test_job_card_partial_material_transfer` test - Use a specific BOM for JC tests - Utility to create said BOM - Sider: unused variable (cherry picked from commit a5f8274) Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com>

* perf(minor): general ledger report (backport frappe#27987) * fix: replaced "=" with "in" for multiple statuses in query (backport frappe#28193) * fix: Serial Nos not set in the row after scanning in popup - Avoid whitspaces while calculating length of serial nos (cherry picked from commit 734b57d) * fix: don't make naming series mandatory for items (backport frappe#28394) * fix: Work order creation from sales order (backport frappe#28388) * fix: currency wise pricing rule not working (cherry picked from commit 43aeb54) * fix: remove item-item group name validation (backport frappe#28392) * fix: Default party account getting overriden in invoices (cherry picked from commit 8864857) * fix: Remove warehouse filter on Batch field for Material Receipt (cherry picked from commit 048210a) * fix: Dispatch address details not displayed in v13 * fix: Unable to edit supplier scorecard criteria name once created (backport frappe#28348) * fix: performance to submit the JV (cherry picked from commit 7472760) * fix: Pricing Rule not created against the Promotional Scheme (cherry picked from commit d82910b) * fix: sum of components in salary register (backport frappe#28237) * fix: auto update price list rate * fix: Pull Items that are in JC in Stock Entry against JC - Check if items pulled in stock entry are present in Job Card - Code cleanup and removed redundant checks Co-authored-by: Gavin D'souza <gavin18d@gmail.com> (cherry picked from commit 3da0302) * test: Stock Entry from JC correctness (items mapping and qty) (cherry picked from commit 0aa237f) * fix: Partial Trabsfers against JC - Fixed transferred qty not back updating on JC if partial transfer - Partial transfer not mapping pending qty from JC correctly in SE - tests for above cases - minor code cleanup (cherry picked from commit e8d0c25) * fix: (travis) Production Plan Summary Report breaks if no WO - `get_cached_value` throws a DoesNotExistError if non-existent value, used `get_value` instead - accomodate production plan items that dont have WO/PO against them as well (blank values) - added some None value handling to avoid AttributeError (cherry picked from commit 1eb3ca2) * fix: Server side test - make `tests_that_skip_setup` a tuple (added comma) - remove manual teardown in `test_job_card_material_transfer_correctness` to avoid premature committing - transfer_material_against = "Job Card" while making BOM with mulitple operations (cherry picked from commit bb561ba) * fix: `test_job_card_partial_material_transfer` test - Use a specific BOM for JC tests - Utility to create said BOM - Sider: unused variable (cherry picked from commit a5f8274) Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com> Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com> Co-authored-by: marination <maricadsouza221197@gmail.com> Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com> Co-authored-by: Subin Tom <subintom2@gmail.com>

perf(general-ledger): skip unnecessary translations

ea2572a

nextchamp-saqib requested a review from deepeshgarg007 as a code owner October 18, 2021 05:27

nextchamp-saqib added 2 commits October 18, 2021 11:33

Merge branch 'develop' of https://github.com/frappe/erpnext into gl-o…

8007dcc

…ptimization

perf(general-ledger): reduce no. of calls to update_value_in_dict

a3be574

nextchamp-saqib changed the title ~~perf(general-ledger): skip unnecessary translations~~ perf(minor): general ledger report Oct 18, 2021

nextchamp-saqib added the dont-merge label Oct 20, 2021

perf(general-ledger): skip unnecessary translations

58eba85

fix: translations

a83249b

nextchamp-saqib added this to In progress in ERPNext Roadmap via automation Nov 3, 2021

nextchamp-saqib added 2 commits November 3, 2021 19:12

fix: net total in case of 'show net values' is checked

ae92864

Merge branch 'develop' of https://github.com/frappe/erpnext into gl-o…

dabccfd

…ptimization

nextchamp-saqib removed the dont-merge label Nov 3, 2021

Merge branch 'develop' into gl-optimization

722d127

nextchamp-saqib merged commit ecbe4b1 into frappe:develop Nov 11, 2021

ERPNext Roadmap automation moved this from In progress to Done Nov 11, 2021

mergify bot pushed a commit that referenced this pull request Nov 11, 2021

perf(minor): general ledger report (#27987)

4d284fe

(cherry picked from commit ecbe4b1) # Conflicts: # erpnext/accounts/report/general_ledger/general_ledger.py

mergify bot mentioned this pull request Nov 11, 2021

perf(minor): general ledger report (backport #27987) #28355

Merged

rohitwaghchaure mentioned this pull request Nov 22, 2021

chore: change log for v13.15.0 #28508

Merged

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022

perf(minor): general ledger report (frappe#27987)

bf99fae

deepeshgarg007 mentioned this pull request Jul 18, 2022

List of V14 features & enhancements #31620

Closed

fproldan added a commit to fproldan/erpnext that referenced this pull request Aug 29, 2022

perf(minor): general ledger report (backport frappe#27987)

7d822f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(minor): general ledger report #27987

perf(minor): general ledger report #27987

nextchamp-saqib commented Oct 18, 2021 •

edited

codecov bot commented Oct 18, 2021 •

edited

szufisher commented Oct 22, 2021

nextchamp-saqib commented Nov 11, 2021

mergify bot commented Nov 11, 2021

nextchamp-saqib commented Nov 11, 2021

mergify bot commented Nov 11, 2021

perf(minor): general ledger report #27987

perf(minor): general ledger report #27987

Conversation

nextchamp-saqib commented Oct 18, 2021 • edited

codecov bot commented Oct 18, 2021 • edited

Codecov Report

szufisher commented Oct 22, 2021

nextchamp-saqib commented Nov 11, 2021

mergify bot commented Nov 11, 2021

❌ No backport have been created

nextchamp-saqib commented Nov 11, 2021

mergify bot commented Nov 11, 2021

✅ Backports have been created

nextchamp-saqib commented Oct 18, 2021 •

edited

codecov bot commented Oct 18, 2021 •

edited