fix: Employee filter in YTD and MTD in salary slip #27997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter for YTD, MTD etc are based on employee name. This seems like an amateur mistake. It should be based on employee id.
govindsmenokee
requested review from
pateljannat and
ruchamahabal
as code owners
pateljannat
approved these changes
Oct 20, 2021
pateljannat
changed the title
|
@Mergifyio backport develop |
✅ Backports have been created
|
pateljannat
added a commit
that referenced
this pull request
Oct 20, 2021
fix: Employee filter in YTD and MTD in salary slip (backport #27997)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
fix: Employee filter in YTD and MTD in salary slip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter for YTD, MTD etc are based on employee name. This seems like an amateur mistake. It should be based on employee id.