Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont recompute item wise taxes from front end #28002

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 19, 2021

Same as #26665 but for frontend tax computation code.

Use case:

  • When using API / integrations there will be cases when computed tax details are available but there's no simple way to add them.
  • Adding this flag allows "Actual" tax type but also lets integrations define how to distribute taxes using the item_wise_tax_details json.

no-docs not intended for users.

@deepeshgarg007 deepeshgarg007 merged commit ddacff3 into frappe:develop Oct 20, 2021
@ankush ankush deleted the dont_recompute_item_tax branch October 20, 2021 13:49
@ankush ankush added the Skip Manual Testing The changes in this PR does not require manual testing label Oct 20, 2021
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants