fix: Fetch thumbnail from Item master instead of regenerating #28005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marination
added
the
e-commerce-fix
- Patch will just fetch thumbnails if website items are created, else it will create new website items
- Thumbnail updation handled via different patch - create_website_items will only have one purpose - added progress bar to `create_website_items` - code cleanup
marination
force-pushed
the
patch-thumbnail-perf
branch
from
ddf6b8f
to
348a961
Compare
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions
|
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Oct 20, 2021
…se/pr-28005 fix: Fetch thumbnail from Item master instead of regenerating (backport #28005)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
fix: Fetch thumbnail from Item master instead of regenerating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fix:
create_website_items, only make web items, nothing else. If web item exists, skip the item.create_website_items