Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Payment Reconciliation): clear child tables on company/party change #28008

Merged

Conversation

Anuja-pawar
Copy link
Contributor

@Anuja-pawar Anuja-pawar commented Oct 19, 2021

Issue:
Screenshot 2021-10-19 at 11 39 04 PM

Steps to replicate:

  1. Select a company, Party Type and Party in Payment Reconciliation
  2. Get unreconciled entries, allocate them
  3. Change the Party. Get unreconciled entries. If you try reconciling without allocating new entries, once the party is changed, you would get the above error because allocation table retains values from the previous allocated entries

Also, closes #14110

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #28008 (133834a) into develop (15e9b51) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28008      +/-   ##
===========================================
- Coverage    55.41%   55.41%   -0.01%     
===========================================
  Files         1248     1248              
  Lines        67715    67715              
===========================================
- Hits         37527    37523       -4     
- Misses       30188    30192       +4     
Impacted Files Coverage Δ
erpnext/accounts/utils.py 59.38% <100.00%> (ø)
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.36% <0.00%> (-0.72%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.41% <0.00%> (-0.70%) ⬇️
... and 12 more

@nextchamp-saqib nextchamp-saqib merged commit 1a6e98e into frappe:develop Oct 29, 2021
@nextchamp-saqib
Copy link
Member

@Mergifyio backport version-13-hotfix

mergify bot pushed a commit that referenced this pull request Oct 29, 2021
…ge (#28008)

(cherry picked from commit 1a6e98e)

# Conflicts:
#	erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

backport version-13-hotfix

✅ Backports have been created

@Anuja-pawar
Copy link
Contributor Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

backport version-13-pre-release

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 2, 2021
…ge (#28008)

(cherry picked from commit 1a6e98e)

# Conflicts:
#	erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment Reconciliation - Company set to Default Company
2 participants