Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove employee_name from job card summary and test all manufacturing reports #28033

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 20, 2021

This field doesn't exist and it's moved on individual line-level logs.

closes #28027

This field doesn't exist and it's moved on individual line level logs.
@ankush ankush added the needs-tests This PR needs automated unit-tests. label Oct 20, 2021
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Oct 20, 2021
@ankush
Copy link
Member Author

ankush commented Oct 20, 2021

linter flagged query pre-existing. wontfix.

@ankush ankush changed the title fix: remove employee_name from job card summary fix: remove employee_name from job card summary and test all manufacturing reports Oct 20, 2021
@ankush ankush added the Skip Manual Testing The changes in this PR does not require manual testing label Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #28033 (f2886c3) into develop (8d9d098) will increase coverage by 0.62%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28033      +/-   ##
===========================================
+ Coverage    54.39%   55.02%   +0.62%     
===========================================
  Files         1255     1255              
  Lines        67851    67851              
===========================================
+ Hits         36910    37334     +424     
+ Misses       30941    30517     -424     
Impacted Files Coverage Δ
...turing/report/job_card_summary/job_card_summary.py 71.21% <ø> (+71.21%) ⬆️
.../report/process_loss_report/process_loss_report.py 84.61% <ø> (+84.61%) ⬆️
...eport/item_variant_details/item_variant_details.py 32.14% <0.00%> (-52.39%) ⬇️
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.81% <0.00%> (-24.53%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.39% <0.00%> (-3.93%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 87.76% <0.00%> (-2.88%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-2.60%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.59% <0.00%> (-2.47%) ⬇️
... and 35 more

@ankush ankush merged commit da3635b into frappe:develop Oct 20, 2021
@ankush ankush deleted the job_card_emloyee_name branch October 20, 2021 15:05
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error show in Job Card Summary report
1 participant