Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates in term loan processing #28034

Merged
merged 10 commits into from
Dec 28, 2021

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 20, 2021

This PR fixes issue in Loan Repayment Schedule Generation that passes over the month of February

Let's say the repayment start date for the loan is 31-01-2021. After the month of Feb every repayment date in the schedule used to become 28 irrespective of the month. This PR fixes that issue

Before:
Screenshot 2021-12-28 at 6 17 19 PM

After:
Screenshot 2021-12-28 at 6 23 53 PM

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #28034 (68d4981) into develop (88df5ce) will increase coverage by 0.04%.
The diff coverage is 85.49%.

@@             Coverage Diff             @@
##           develop   #28034      +/-   ##
===========================================
+ Coverage    55.67%   55.71%   +0.04%     
===========================================
  Files         1128     1129       +1     
  Lines        67335    67471     +136     
===========================================
+ Hits         37488    37593     +105     
- Misses       29847    29878      +31     
Impacted Files Coverage Δ
...anagement/doctype/loan_repayment/loan_repayment.py 89.10% <83.03%> (+1.72%) ⬆️
erpnext/loan_management/doctype/loan/loan.py 70.99% <100.00%> (+0.44%) ⬆️
...ement/doctype/loan_application/loan_application.py 64.34% <100.00%> (ø)
...ent/doctype/loan_disbursement/loan_disbursement.py 71.42% <100.00%> (-0.27%) ⬇️
...ype/loan_interest_accrual/loan_interest_accrual.py 90.99% <100.00%> (+3.71%) ⬆️
...e/loan_security_unpledge/loan_security_unpledge.py 77.21% <100.00%> (-0.29%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.60% <0.00%> (-2.44%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
... and 18 more

@stale
Copy link

stale bot commented Nov 9, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 9, 2021
@stale stale bot closed this Nov 12, 2021
@stale stale bot removed the inactive label Nov 15, 2021
@stale
Copy link

stale bot commented Nov 30, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 30, 2021
@deepeshgarg007
Copy link
Member Author

Keep-alive!

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Dec 28, 2021
…-28034

fix: Updates in term loan processing (backport #28034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant