Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UX): Add mandatory depends on condition for reference no and date fields #28055

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 21, 2021

In payment entry if any of the accounts either Paid From or to is a bank account then user used to get a server side validation for missing reference no and date

In this case neither mandatory indicator shown on these fields nor the user was scrolled to the missing fields.
Added mandatory_depends_on_condition so that both of these things happen for better UX

@deepeshgarg007 deepeshgarg007 changed the title fix(minor): Add mandatory depends on condition for reference no and d… fix(minor): Add mandatory depends on condition for reference no and date fields Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #28055 (a20058a) into develop (2849297) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #28055      +/-   ##
===========================================
+ Coverage    55.19%   55.22%   +0.03%     
===========================================
  Files         1255     1255              
  Lines        67871    67871              
===========================================
+ Hits         37460    37483      +23     
+ Misses       30411    30388      -23     
Impacted Files Coverage Δ
erpnext/stock/reorder_item.py 76.27% <0.00%> (-0.85%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 80.00% <0.00%> (-0.84%) ⬇️
erpnext/stock/get_item_details.py 79.38% <0.00%> (-0.47%) ⬇️
erpnext/hr/utils.py 74.29% <0.00%> (-0.41%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 76.39% <0.00%> (-0.38%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 76.58% <0.00%> (-0.09%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.31% <0.00%> (ø)
erpnext/projects/doctype/project/project.py 54.25% <0.00%> (+0.35%) ⬆️
erpnext/support/doctype/issue/issue.py 64.56% <0.00%> (+0.97%) ⬆️
erpnext/controllers/stock_controller.py 90.76% <0.00%> (+1.05%) ⬆️
... and 4 more

@deepeshgarg007 deepeshgarg007 changed the title fix(minor): Add mandatory depends on condition for reference no and date fields fix(UX): Add mandatory depends on condition for reference no and date fields Oct 26, 2021
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 27, 2021
…-28055

fix(UX): Add mandatory depends on condition for reference no and date fields (backport #28055)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…fix/pr-28055

fix(UX): Add mandatory depends on condition for reference no and date fields (backport frappe#28055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant