-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : Get LTDS based on tax withholding category #28071
Merged
deepeshgarg007
merged 5 commits into
frappe:develop
from
deepeshgarg007:lower_deduction_cetificate_fixes
Oct 28, 2021
Merged
fix : Get LTDS based on tax withholding category #28071
deepeshgarg007
merged 5 commits into
frappe:develop
from
deepeshgarg007:lower_deduction_cetificate_fixes
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28071 +/- ##
========================================
Coverage 55.39% 55.40%
========================================
Files 1248 1248
Lines 67681 67681
========================================
+ Hits 37494 37498 +4
+ Misses 30187 30183 -4
|
…r_deduction_cetificate_fixes
…r_deduction_cetificate_fixes
deepeshgarg007
force-pushed
the
lower_deduction_cetificate_fixes
branch
from
October 28, 2021 13:32
998afa1
to
812249e
Compare
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Oct 29, 2021
…-28071 fix : Get LTDS based on tax withholding category (backport #28071)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…fix/pr-28071 fix : Get LTDS based on tax withholding category (backport frappe#28071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace section code in Lower Deduction certificate with Tax Withholding Category
Currently, the Lower Deduction Certificate is applied on the basis of PAN No.
Let's say there are two supplier masters with the Same PAN No and two certificates are made against each supplier for different categories, only one rate is applied against both categories since the identification is done on basis of PAN. Added Tax Withholding Category in LDC so that lower rate can be applied on the basis of tax category