fix: Move PAN field from standard doctype to fixtures for India #28074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
ankush,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
deepeshgarg007
added
the
Skip Manual Testing
Codecov Report
@@ Coverage Diff @@
## develop #28074 +/- ##
===========================================
+ Coverage 55.09% 55.17% +0.08%
===========================================
Files 1255 1255
Lines 67875 67877 +2
===========================================
+ Hits 37393 37450 +57
+ Misses 30482 30427 -55
|
neldeles
added a commit
to neldeles/erpnext
that referenced
this pull request
Jul 18, 2023
If pan column is missing from the Supplier doctype use tax_id instead. pan can be missing because of changes made in PR frappe#28074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier PAN No field was added as a standard field in the Supplier/Customer master.
PAN No field is primarily used in India only so moved the field as a fixture in regional setup for India and added a patch to handle existing records