Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Payment Terms validation precision #28080

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Oct 25, 2021

image

Due to precision issues while validating payment terms user used to get the above error on saving a document

An example where this issue used to happen is as follows

  1. Make a sales Invoice with net total amount of 232177.80 with no taxes and enable rounding
    image

  2. Add a payment terms template as follows with the following terms
    image

Try saving the order

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #28080 (9c17052) into develop (fdaf93f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28080      +/-   ##
===========================================
+ Coverage    55.09%   55.19%   +0.10%     
===========================================
  Files         1255     1255              
  Lines        67875    67877       +2     
===========================================
+ Hits         37393    37465      +72     
+ Misses       30482    30412      -70     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 83.56% <100.00%> (ø)
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.80% <0.00%> (-3.66%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.00% <0.00%> (-3.23%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-2.98%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 88.48% <0.00%> (-2.88%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.59% <0.00%> (-2.47%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-1.30%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 78.82% <0.00%> (-0.59%) ⬇️
erpnext/accounts/utils.py 59.19% <0.00%> (-0.19%) ⬇️
... and 12 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant