Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): misc ux issues #28111

Merged
merged 4 commits into from
Oct 27, 2021
Merged

fix(ux): misc ux issues #28111

merged 4 commits into from
Oct 27, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 27, 2021

  • arbitrary hardcoded number for sorting 9999 replaced with float('inf') 🤡
  • two way alternative item validation both item should have "allow alternative item" checked if two way is checked.
  • don't show blocked suppliers in autocomplete. (at least wherever supplier query is used, e.g. PO, PI)
  • make Work Order qty 1 by default so required items table can be populated on selecting item.

@ankush ankush changed the title fix(ux): misc ux issues in work order fix(ux): misc ux issues Oct 27, 2021
@ankush
Copy link
Member Author

ankush commented Oct 27, 2021

raw query - not new, just moved.

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #28111 (91cae1c) into develop (e0cf45e) will decrease coverage by 0.06%.
The diff coverage is 10.00%.

@@             Coverage Diff             @@
##           develop   #28111      +/-   ##
===========================================
- Coverage    55.12%   55.05%   -0.07%     
===========================================
  Files         1255     1255              
  Lines        67929    67934       +5     
===========================================
- Hits         37448    37404      -44     
- Misses       30481    30530      +49     
Impacted Files Coverage Δ
erpnext/controllers/queries.py 60.32% <ø> (ø)
...stock/doctype/item_alternative/item_alternative.py 0.00% <0.00%> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 73.33% <100.00%> (ø)
erpnext/utilities/product.py 15.94% <0.00%> (-34.79%) ⬇️
erpnext/shopping_cart/product_info.py 32.35% <0.00%> (-20.59%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 87.01% <0.00%> (-2.60%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.59% <0.00%> (-2.47%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.20% <0.00%> (-2.16%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 66.03% <0.00%> (-1.89%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
... and 15 more

@ankush ankush enabled auto-merge (rebase) October 27, 2021 14:15
@ankush ankush disabled auto-merge October 27, 2021 14:15
@ankush ankush merged commit d81b87d into frappe:develop Oct 27, 2021
@ankush ankush deleted the misc_wo_fixes branch October 27, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant