Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bank Reconciliation): get credit amount for bank account of type liability #28132

Merged
merged 4 commits into from
Nov 10, 2021

Conversation

Anuja-pawar
Copy link
Contributor

@Anuja-pawar Anuja-pawar commented Oct 29, 2021

If a bank account is of type Liability (eg. Credit Card Account)
As credits increase Liability accounts, and debits decrease Liability accounts
Deposit should be matched against credit amount from Journal Entry, and Withdrawal should be matched against debit amount unlike Asset accounts.

Reference: ISS-21-22-07465

Steps to recreate:

  1. Create Account of type Bank having Root Type Liability
For example

Screenshot 2021-10-29 at 12 11 27 PM

  1. Create Bank Account for the same
For example

Screenshot 2021-10-29 at 12 17 28 PM

  1. Create a Journal Entry for this account
For example

Screenshot 2021-10-29 at 12 21 58 PM

  1. Create Bank Transaction for this (manually)
    set the Deposit & Unallocated Amount accordingly
For example

Screenshot 2021-10-29 at 12 24 28 PM

  1. Try reconciling this transaction in Bank Reconciliation Tool. You would get journal entry amount zero while matching the voucher against transaction

Screenshot 2021-10-29 at 1 20 51 PM

Before

ezgif com-gif-maker (1)

After

ezgif com-gif-maker (2)

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #28132 (54bf8b7) into develop (2da1703) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop   #28132   +/-   ##
========================================
  Coverage    55.23%   55.23%           
========================================
  Files         1117     1117           
  Lines        66494    66498    +4     
========================================
+ Hits         36729    36732    +3     
- Misses       29765    29766    +1     
Impacted Files Coverage Δ
...nk_reconciliation_tool/bank_reconciliation_tool.py 44.11% <0.00%> (-1.07%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
erpnext/accounts/deferred_revenue.py 75.11% <0.00%> (-0.89%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-0.86%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 77.23% <0.00%> (-0.82%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 76.30% <0.00%> (-0.75%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.83% <0.00%> (-0.44%) ⬇️
erpnext/stock/get_item_details.py 79.60% <0.00%> (+0.15%) ⬆️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 71.02% <0.00%> (+0.23%) ⬆️
... and 10 more

@nextchamp-saqib nextchamp-saqib added the needs-tests This PR needs automated unit-tests. label Oct 29, 2021
@nextchamp-saqib nextchamp-saqib merged commit 2f00469 into frappe:develop Nov 10, 2021
@nextchamp-saqib
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2021

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants