Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Print Format): KSA VAT Invoice #28166

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Conversation

ahmadpak
Copy link
Contributor

@ahmadpak ahmadpak commented Oct 30, 2021

Continuation of the KSA VAT feature. New print format for KSAVAT

image

no-docs

@ghost
Copy link

ghost commented Oct 30, 2021

✅ Sider has resolved the errors or warnings via the commit 8df50cf! See the analysis result for details.


You can turn off such notifications if unnecessary.

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #28166 (8df50cf) into develop (fb9e72c) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28166      +/-   ##
===========================================
- Coverage    55.39%   55.20%   -0.19%     
===========================================
  Files         1248     1117     -131     
  Lines        67721    66495    -1226     
===========================================
- Hits         37512    36710     -802     
+ Misses       30209    29785     -424     
Impacted Files Coverage Δ
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (ø)
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...pnext/agriculture/doctype/fertilizer/fertilizer.py 57.14% <0.00%> (-5.36%) ⬇️
erpnext/utilities/activation.py 14.28% <0.00%> (-4.64%) ⬇️
erpnext/education/doctype/article/article.py 38.46% <0.00%> (-4.40%) ⬇️
erpnext/controllers/print_settings.py 15.78% <0.00%> (-4.22%) ⬇️
erpnext/setup/doctype/party_type/party_type.py 54.54% <0.00%> (-3.79%) ⬇️
..._scorecard_standing/supplier_scorecard_standing.py 60.00% <0.00%> (-3.64%) ⬇️
...next/hr/doctype/interview_round/interview_round.py 35.29% <0.00%> (-3.60%) ⬇️
...next/regional/doctype/gst_hsn_code/gst_hsn_code.py 35.29% <0.00%> (-3.60%) ⬇️
... and 1174 more

@deepeshgarg007 deepeshgarg007 changed the title new (Print Format): KSA VAT Invoice feat(Print Format): KSA VAT Invoice Oct 31, 2021
@mhbu50
Copy link
Contributor

mhbu50 commented Nov 1, 2021

  • include TAX ID for both (Customer/Supplier) and the company
  • Remove Green color for headers

@nextchamp-saqib nextchamp-saqib added this to In progress in ERPNext Roadmap via automation Nov 3, 2021
- KSA VAT Invoice
Customer Identification Number Added
@ahmadpak
Copy link
Contributor Author

ahmadpak commented Nov 8, 2021

@mhbu50 Tax Identification Numbers will show up if added.
image

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007 deepeshgarg007 merged commit 419e039 into frappe:develop Nov 8, 2021
ERPNext Roadmap automation moved this from In progress to Done Nov 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-pre-release

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Nov 8, 2021
…-28166

feat(Print Format): KSA VAT Invoice (backport #28166)
deepeshgarg007 added a commit that referenced this pull request Nov 8, 2021
…se/pr-28166

feat(Print Format): KSA VAT Invoice (backport #28166)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…-release/pr-28166

feat(Print Format): KSA VAT Invoice (backport frappe#28166)
@ahmadpak ahmadpak deleted the ksa-vat branch November 24, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants