Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass company while fetching valuation rate #28178

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Nov 1, 2021

If company is not supplied and valuation rate is 0, then default company is used for checking if perpetual inventory is enabled or not.

This makes little sense as different companies can have different settings for perpetual inventory.

If company is not supplied and valuation rate is 0, then default
company is used for checking if perpetual inventory is enabled or not.
This makes little sense as different companies can have different
setting for perpetual inventory.
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #28178 (b01d70d) into develop (ddcdf64) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28178      +/-   ##
===========================================
+ Coverage    55.39%   55.43%   +0.04%     
===========================================
  Files         1248     1248              
  Lines        67721    67721              
===========================================
+ Hits         37516    37544      +28     
+ Misses       30205    30177      -28     
Impacted Files Coverage Δ
erpnext/stock/stock_ledger.py 86.59% <0.00%> (+1.08%) ⬆️
erpnext/stock/report/stock_ageing/stock_ageing.py 88.48% <0.00%> (-4.32%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.56% <0.00%> (-3.78%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.00% <0.00%> (-3.23%) ⬇️
erpnext/education/doctype/student/student.py 73.95% <0.00%> (-3.13%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-2.98%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.59% <0.00%> (-2.47%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 45.09% <0.00%> (-1.97%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/stock/reorder_item.py 76.27% <0.00%> (-0.85%) ⬇️
... and 16 more

@ankush
Copy link
Member Author

ankush commented Nov 1, 2021

(this doesn't need coverage, very basic get_value query 😄 )

@ankush ankush enabled auto-merge (rebase) November 1, 2021 08:43
@ankush ankush disabled auto-merge November 1, 2021 08:43
@ankush ankush merged commit f7ffe04 into frappe:develop Nov 1, 2021
@ankush ankush deleted the pass_company_for_valuation branch November 1, 2021 08:43
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants