Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (ux) Remove warehouse filter on Batch field for Material Receipt #28195

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

marination
Copy link
Collaborator

Issue:

  • Consider a Batch that is manually created, and has no warehouse against it and is empty
  • Create a Stock Entry (Material Receipt), add a target warehouse, add a row for the batched item. Try to add manually created batch in Batch No field
  • You cannot, since there is a warehouse filter.
    photo_2021-11-02 15 52 45

Fix:

  • Only for Material Receipt, avoid adding warehouse filter
  • User should be able to select a new empty batch or a pre-existing batch (for adjustment and return purposes) in this Receipt
    Screenshot 2021-11-02 at 3 54 51 PM

@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

backport version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@marination
Copy link
Collaborator Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

backport version-12-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@marination marination changed the title fix: Remove warehouse filter on Batch field for Material Receipt fix: (ux) Remove warehouse filter on Batch field for Material Receipt Nov 2, 2021
@marination marination merged commit 11c0b37 into frappe:develop Nov 2, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

backport version-13-pre-release

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

backport version-13-hotfix

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

backport version-12-hotfix

✅ Backports have been created

marination added a commit that referenced this pull request Nov 2, 2021
…-28195

fix: (ux) Remove warehouse filter on Batch field for Material Receipt (backport #28195)
marination added a commit that referenced this pull request Nov 2, 2021
…se/pr-28195

fix: (ux) Remove warehouse filter on Batch field for Material Receipt (backport #28195)
marination added a commit that referenced this pull request Nov 2, 2021
…-28195

fix: (ux) Remove warehouse filter on Batch field for Material Receipt (backport #28195)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…-release/pr-28195

fix: (ux) Remove warehouse filter on Batch field for Material Receipt (backport frappe#28195)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant