-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: over billing validation #28218
fix: over billing validation #28218
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28218 +/- ##
===========================================
+ Coverage 55.24% 57.89% +2.64%
===========================================
Files 1255 1250 -5
Lines 67935 93176 +25241
===========================================
+ Hits 37534 53941 +16407
- Misses 30401 39235 +8834
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
(cherry picked from commit 9c913c9)
Steps to replicate the issue:
The Sales Invoice is submitted with double the qty as in Delivery Note, basically bypassing over-billing validation
This happens because over-billing validation only considers Sales Invoice Items from other submitted invoices, it doesn't consider items from itself that is being submitted.