Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect job card status #28224

Merged
merged 3 commits into from
Nov 9, 2021
Merged

fix: incorrect job card status #28224

merged 3 commits into from
Nov 9, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Nov 3, 2021

  • Fix incorrect job card status. use completed quantity instead of transfer qty for 'Completed' status
  • unrelated fix: possible runtime error when modifying dict and its keys() iterators together.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #28224 (3176912) into develop (aed45f2) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28224      +/-   ##
===========================================
- Coverage    55.18%   55.13%   -0.06%     
===========================================
  Files         1117     1117              
  Lines        66491    66491              
===========================================
- Hits         36695    36657      -38     
- Misses       29796    29834      +38     
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/job_card/job_card.py 64.45% <100.00%> (ø)
erpnext/stock/doctype/stock_entry/stock_entry.py 79.76% <100.00%> (ø)
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 88.32% <0.00%> (-3.65%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-2.98%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.44% <0.00%> (-2.97%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.05% <0.00%> (-1.50%) ⬇️
... and 15 more

@ankush ankush added the needs-patch A patch to fix existing data is required label Nov 3, 2021
@ankush ankush removed the needs-patch A patch to fix existing data is required label Nov 7, 2021
@ankush ankush marked this pull request as ready for review November 7, 2021 12:56
@ankush ankush merged commit ccf84ae into frappe:develop Nov 9, 2021
@ankush ankush deleted the jc_status branch November 9, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants