fix: Pull only Items that are in Job Card in a Stock Entry against Job Card #28228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if items pulled in stock entry are present in Job Card - Code cleanup and removed redundant checks Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
|
This simplifies solution for #27887 😄 Just need to fetch name and map it to |
Codecov Report
@@ Coverage Diff @@
## develop #28228 +/- ##
===========================================
+ Coverage 55.14% 55.25% +0.11%
===========================================
Files 1119 1119
Lines 66571 66594 +23
===========================================
+ Hits 36709 36796 +87
+ Misses 29862 29798 -64
|
marination
force-pushed
the
se-required-items-from-jc
branch
from
232d0ab
to
0aa237f
Compare
- Fixed transferred qty not back updating on JC if partial transfer - Partial transfer not mapping pending qty from JC correctly in SE - tests for above cases - minor code cleanup
- `get_cached_value` throws a DoesNotExistError if non-existent value, used `get_value` instead - accomodate production plan items that dont have WO/PO against them as well (blank values) - added some None value handling to avoid AttributeError
- make `tests_that_skip_setup` a tuple (added comma) - remove manual teardown in `test_job_card_material_transfer_correctness` to avoid premature committing - transfer_material_against = "Job Card" while making BOM with mulitple operations
- Use a specific BOM for JC tests - Utility to create said BOM - Sider: unused variable
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Nov 16, 2021
…-28228 fix: Pull only Items that are in Job Card in a Stock Entry against Job Card (backport #28228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fix:
To Test:
Create BOM with Items A, B and C. And also with operations C and D
Add Operation C against Items A and B, and Operation D against item C
Create a Work Order (for 2 qty) against this BOM > Set Material Transfer against as Job Card
Submit Work Order. Go to Job Card of operation C.
Click on Material Transfer. Stock Entry is created for 2 FG qty. Items table has items A and B
Edit the For Quantity field to 1 (partial transfer), the Items table has items A, B and C
Expected: Edit the For Quantity field to 1 (partial transfer), the Items table has items A and B
Test BUG - Job Card Item Transferred Qty is not assigned #27887 as well