fix: Taxjar customer_address fix, currency fix #28262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesis189
requested review from
deepeshgarg007
and removed request for
nextchamp-saqib
nemesis189
changed the title
deepeshgarg007
changed the title
deepeshgarg007
requested changes
Nov 8, 2021
erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.json
Outdated
Show resolved
Hide resolved
|
@Mergifyio backport develop |
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions to match
|
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 8, 2021
…se/pr-28262 fix: Taxjar customer_address fix, currency fix (backport #28262)
deepeshgarg007
added a commit
that referenced
this pull request
Nov 8, 2021
fix: Taxjar customer_address fix, currency fix (backport #28262)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…-release/pr-28262 fix: Taxjar customer_address fix, currency fix (backport frappe#28262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
customer_address_namewas wrong variable, corrected it tocustomer_addresscurrencyto 'options' of Tax Collectable and Taxable Amount fields