Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: (ux) Accepted/Rejected/Received Qty UX #28269

Merged
merged 6 commits into from
Nov 16, 2021
Merged

refactor: (ux) Accepted/Rejected/Received Qty UX #28269

merged 6 commits into from
Nov 16, 2021

Conversation

marination
Copy link
Collaborator

@marination marination commented Nov 8, 2021 •
edited

Issue:

  • The Accepted/Rejected/Received Qty UX is extremely confusing.
  • On adjusting the rejected qty, the accepted and received qty changed. Given three editable fields, it increases the combinations of calculations and field modifications.

Fix: (in PR and PI)

  • Make it easier on the user as to which fields to set
  • Made Received Qty field read only. Users must set Accepted Qty and/or Rejected Qty. They simply add up to the Received Qty.
    PR-UX
  • Rejected Qty bought to Grid View in PR only (not in PI as it depends on Update Stock)

ToDo:

  • Test return case validations

this needs UX testing

@marination marination changed the title refactor: (ux) Accepted/Rejected/Received Qty UX refactor: [WIP] (ux) Accepted/Rejected/Received Qty UX Nov 8, 2021
@ankush ankush linked an issue Nov 8, 2021 that may be closed by this pull request
Purchase receipt- return and reject flow improvement #28266
Closed
@codecov
Copy link

codecov bot commented Nov 8, 2021 •
edited

Codecov Report

Merging #28269 (4afcbfd) into develop (aaf0e4e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28269      +/-   ##
===========================================
+ Coverage    55.23%   55.26%   +0.03%     
===========================================
  Files         1119     1119              
  Lines        66569    66568       -1     
===========================================
+ Hits         36767    36791      +24     
+ Misses       29802    29777      -25
Impacted Files Coverage Δ
erpnext/controllers/buying_controller.py 86.84% <100.00%> (+0.44%) ⬆️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.05% <0.00%> (-1.50%) ⬇️
erpnext/accounts/deferred_revenue.py 75.11% <0.00%> (-0.89%) ⬇️
erpnext/stock/stock_ledger.py 85.63% <0.00%> (-0.73%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.83% <0.00%> (-0.44%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 77.50% <0.00%> (-0.39%) ⬇️
erpnext/projects/doctype/project/project.py 53.73% <0.00%> (-0.36%) ⬇️
... and 12 more

@marination marination changed the title refactor: [WIP] (ux) Accepted/Rejected/Received Qty UX refactor: (ux) Accepted/Rejected/Received Qty UX Nov 9, 2021
@marination marination added the fix-sider-issues Check and fix issues listed by Sider label Nov 10, 2021
@marination
fix: Sider + Fields UX
afe1c45 
- remove extra space (sider)
- PR: Bring rejected qty in grid view
- PI: Rename `Stock Qty` to `Accepted Qty in Stock UOM`
- PI: Move `Accepted Qty in Stock UOM` under Stock UOM
@marination
test: Purchase Receipt Received Qty
05ec7cc
@marination
test: Purchase Invoice Received Qty
e9c75d6
@marination
fix: Sider, Linter and Server Side Test
293f6cb 
- Fix Server side PR test
- linter: re-arrange imports
- sider: avoid single line multi statement
- Code cleanup: Improve code readability and avoid horizontal scroll in test_purchase_receipt
- Removed unused variables in test_purchase_receipt
@marination marination removed the fix-sider-issues Check and fix issues listed by Sider label Nov 16, 2021
@marination marination merged commit 6bd0c1d into frappe:develop Nov 16, 2021
@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify mergify bot mentioned this pull request Nov 16, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

backport version-13-hotfix

✅ Backports have been created

marination added a commit that referenced this pull request Nov 18, 2021
@marination
Merge pull request #28412 from frappe/mergify/bp/version-13-hotfix/pr…
4a4b327 
…-28269

refactor:  (ux) Accepted/Rejected/Received Qty UX (backport #28269)
@rohitwaghchaure rohitwaghchaure mentioned this pull request Dec 5, 2021
Merged
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush Awaiting requested review from ankush

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purchase receipt- return and reject flow improvement
1 participant
@marination