Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KSA VAT setup issues #28272

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Nov 8, 2021

  • KSA VAT Settings bootstrap issues

    1. Create Account for VAT 5%
    2. Custom fields not updated in database
  • Patch to create custom fields

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #28272 (508832e) into develop (419e039) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28272      +/-   ##
===========================================
- Coverage    55.27%   55.27%   -0.01%     
===========================================
  Files         1117     1117              
  Lines        66495    66490       -5     
===========================================
- Hits         36754    36751       -3     
+ Misses       29741    29739       -2     
Impacted Files Coverage Δ
erpnext/regional/report/ksa_vat/ksa_vat.py 0.00% <0.00%> (ø)
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (ø)
..._arabia/wizard/operations/setup_ksa_vat_setting.py 0.00% <ø> (ø)
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
erpnext/stock/reorder_item.py 75.21% <0.00%> (-1.71%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.05% <0.00%> (-1.50%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.13% <0.00%> (-0.70%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.24% <0.00%> (-0.69%) ⬇️
... and 15 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007 deepeshgarg007 merged commit 2bf3b0f into frappe:develop Nov 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-pre-release

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Nov 8, 2021
…-28272

fix: KSA VAT setup issues (backport #28272)
deepeshgarg007 added a commit that referenced this pull request Nov 8, 2021
…se/pr-28272

fix: KSA VAT setup issues (backport #28272)
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…-release/pr-28272

fix: KSA VAT setup issues (backport frappe#28272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant