Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shipping Rule picking up old net_rate #28302

Merged

Conversation

nemesis189
Copy link
Contributor

@nemesis189 nemesis189 commented Nov 9, 2021

Problem:

  • On applying a shipping rule in an invoice, it was making use of the old net_rate to calculate the charges.

Solution:

  • Calling the shipping rule calculation method in net total

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #28302 (a8e2c02) into develop (043e325) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a8e2c02 differs from pull request most recent head e7b4204. Consider uploading reports for the commit e7b4204 to get more accurate results

@@           Coverage Diff            @@
##           develop   #28302   +/-   ##
========================================
  Coverage    55.19%   55.20%           
========================================
  Files         1119     1119           
  Lines        66529    66599   +70     
========================================
+ Hits         36722    36764   +42     
- Misses       29807    29835   +28     
Impacted Files Coverage Δ
erpnext/controllers/taxes_and_totals.py 97.65% <100.00%> (+0.02%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-22.42%) ⬇️
...s/doctype/promotional_scheme/promotional_scheme.py 91.36% <0.00%> (-4.60%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.05% <0.00%> (-1.46%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
... and 29 more

@deepeshgarg007 deepeshgarg007 merged commit a57d399 into frappe:develop Nov 19, 2021
@nemesis189
Copy link
Contributor Author

@Mergifyio backport version-13-hotfix version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2021

backport version-13-hotfix version-13-pre-release

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Dec 3, 2021
…-28302

fix: Shipping Rule picking up old net_rate (backport #28302)
deepeshgarg007 added a commit that referenced this pull request Dec 3, 2021
…se/pr-28302

fix: Shipping Rule picking up old net_rate (backport #28302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants