Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default value for allow neg stock in repost_item_valuation #28320

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Nov 10, 2021

Negative stock can be toggled back after queuing transactions, this
causes failure when repost is executed.

Now allow_negative_stock stock is set at time of queuing the repost job.
This means setting changes done afterwards won't affect already
submitted reposts.

Negative stock can be toggled back after queuing transactions, this
causes failure when repost is executed.

Now allow_negative_stock stock is set at time of queuing the repost job.
This means setting changes done afterwards won't affect already
submitted reposts.
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #28320 (485372c) into develop (6954dd6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28320      +/-   ##
===========================================
+ Coverage    55.16%   55.23%   +0.06%     
===========================================
  Files         1119     1119              
  Lines        66534    66539       +5     
===========================================
+ Hits         36703    36751      +48     
+ Misses       29831    29788      -43     
Impacted Files Coverage Δ
...ype/repost_item_valuation/repost_item_valuation.py 66.66% <100.00%> (+0.32%) ⬆️
erpnext/stock/report/stock_ledger/stock_ledger.py 74.79% <0.00%> (-3.26%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.30% <0.00%> (-1.93%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
...nk_reconciliation_tool/bank_reconciliation_tool.py 44.11% <0.00%> (-1.07%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 76.67% <0.00%> (-0.38%) ⬇️
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.79% <0.00%> (-0.24%) ⬇️
erpnext/accounts/utils.py 59.23% <0.00%> (+0.18%) ⬆️
... and 14 more

@ankush ankush merged commit 12e81df into frappe:develop Nov 10, 2021
@ankush ankush deleted the neg_stock_reposts branch November 10, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant