Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not cancel stock reconciliation with sr no #28343

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Nov 11, 2021

Steps to reproduce:

  1. Create stock entry with serialized items of qty 10
  2. Create stock reconciliation and reduce the quantity to 9 by removing one Sr no.
  3. Try to cancel the stock reco, it will fail saying sr no doesn't belong to warehouse.

Solution: ignore none warehouse while canceling Stock recos.

Disclaimer: I am fully aware how bad this looks now 😄 cleaning up the code in separate PR, this fix can't wait till I am done with #28326

@ankush ankush added the needs-tests This PR needs automated unit-tests. label Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #28343 (67fe702) into develop (ce06aaa) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28343      +/-   ##
===========================================
+ Coverage    55.20%   55.25%   +0.04%     
===========================================
  Files         1119     1119              
  Lines        66537    66529       -8     
===========================================
+ Hits         36734    36759      +25     
+ Misses       29803    29770      -33     
Impacted Files Coverage Δ
erpnext/stock/doctype/serial_no/serial_no.py 78.75% <100.00%> (ø)
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.05% <0.00%> (-1.50%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/stock/stock_ledger.py 85.63% <0.00%> (-1.10%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.24% <0.00%> (-0.69%) ⬇️
erpnext/setup/doctype/item_group/item_group.py 48.40% <0.00%> (-0.67%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.74% <0.00%> (-0.57%) ⬇️
... and 19 more

@ankush ankush added this to the v13.15 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant