Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regional): hsn_wise as false returns item_code #28385

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

vorasmit
Copy link
Collaborator

If hsn_wise was false, it returns item_code which need not be an integer.
Also renamed variable to define what it means.

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #28385 (e5ca9f3) into develop (c0cc72e) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28385      +/-   ##
===========================================
- Coverage    55.32%   55.23%   -0.10%     
===========================================
  Files         1120     1120              
  Lines        66675    66675              
===========================================
- Hits         36887    36825      -62     
- Misses       29788    29850      +62     
Impacted Files Coverage Δ
erpnext/regional/india/utils.py 63.60% <100.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-22.42%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 90.38% <0.00%> (-1.93%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
erpnext/support/doctype/issue/issue.py 63.41% <0.00%> (-0.98%) ⬇️
erpnext/accounts/deferred_revenue.py 75.11% <0.00%> (-0.89%) ⬇️
... and 15 more

@stale
Copy link

stale bot commented Nov 29, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 29, 2021
@stale stale bot removed the inactive label Nov 29, 2021
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2021

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants