-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: POS idx issue in taxes table while merging #28389
Merged
nextchamp-saqib
merged 3 commits into
frappe:develop
from
nemesis189:pos-sales-taxes-idx-issue
Nov 16, 2021
Merged
fix: POS idx issue in taxes table while merging #28389
nextchamp-saqib
merged 3 commits into
frappe:develop
from
nemesis189:pos-sales-taxes-idx-issue
Nov 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28389 +/- ##
===========================================
- Coverage 55.24% 55.23% -0.02%
===========================================
Files 1119 1119
Lines 66553 66572 +19
===========================================
Hits 36768 36768
- Misses 29785 29804 +19
|
erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.py
Outdated
Show resolved
Hide resolved
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2021
(cherry picked from commit a1807a2)
✅ Backports have been created
|
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
While merging POS invoices, the idx parameter was not being tracked so during calculation of taxes it would get overwritten
Solution:
Keeping track of idx in the merging logic itself where taxes are added