Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: POS idx issue in taxes table while merging #28389

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

nemesis189
Copy link
Contributor

Problem:
While merging POS invoices, the idx parameter was not being tracked so during calculation of taxes it would get overwritten

Solution:
Keeping track of idx in the merging logic itself where taxes are added

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #28389 (a429820) into develop (c0f06bc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28389      +/-   ##
===========================================
- Coverage    55.24%   55.23%   -0.02%     
===========================================
  Files         1119     1119              
  Lines        66553    66572      +19     
===========================================
  Hits         36768    36768              
- Misses       29785    29804      +19     
Impacted Files Coverage Δ
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 75.92% <100.00%> (+0.27%) ⬆️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...s/doctype/promotional_scheme/promotional_scheme.py 91.36% <0.00%> (-4.60%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 90.51% <0.00%> (-2.92%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 91.37% <0.00%> (-1.73%) ⬇️
erpnext/stock/reorder_item.py 74.35% <0.00%> (-1.71%) ⬇️
... and 25 more

@nextchamp-saqib
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@nextchamp-saqib nextchamp-saqib merged commit a1807a2 into frappe:develop Nov 16, 2021
mergify bot pushed a commit that referenced this pull request Nov 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

backport version-13-hotfix

✅ Backports have been created

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants