-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: currency wise pricing rule not working #28417
Merged
rohitwaghchaure
merged 1 commit into
frappe:develop
from
rohitwaghchaure:currency-wise-pricing-rule-not-working
Nov 17, 2021
Merged
fix: currency wise pricing rule not working #28417
rohitwaghchaure
merged 1 commit into
frappe:develop
from
rohitwaghchaure:currency-wise-pricing-rule-not-working
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
November 16, 2021 14:19
rohitwaghchaure
force-pushed
the
currency-wise-pricing-rule-not-working
branch
from
November 17, 2021 07:59
f6f70ad
to
1fe67d6
Compare
rohitwaghchaure
force-pushed
the
currency-wise-pricing-rule-not-working
branch
from
November 17, 2021 08:00
1fe67d6
to
43aeb54
Compare
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
@Mergifyio backport version-13-pre-release |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
✅ Backports have been created
|
rohitwaghchaure
added a commit
that referenced
this pull request
Nov 17, 2021
…se/pr-28417 fix: currency wise pricing rule not working (backport #28417)
rohitwaghchaure
added a commit
that referenced
this pull request
Nov 17, 2021
…-28417 fix: currency wise pricing rule not working (backport #28417)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Create two different pricing rules for the same item with different currency and different Rate and set priority to high to the currency INR
In the transaction, select the currency as USD and check
System fetched the Pricing Rule with the currency as INR and not the Pricing Rule with currency as USD
Expected Output
System should fetch the pricing rule as per Transaction Currency