Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buying): quotation number in supplier quotation #28420

Merged
merged 12 commits into from
Dec 11, 2021

Conversation

hrwX
Copy link
Contributor

@hrwX hrwX commented Nov 16, 2021

  • Add Quotation Number in Supplier Quotation similar to Order Confirmation Number in Purchase Order.

Docs: https://docs.erpnext.com/docs/v13/user/manual/en/buying/supplier-quotation#32-more

@barredterra
Copy link
Collaborator

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@barredterra
Copy link
Collaborator

@hrwX
Copy link
Contributor Author

hrwX commented Nov 23, 2021

barredterra
barredterra previously approved these changes Nov 23, 2021
@barredterra barredterra enabled auto-merge (squash) November 24, 2021 09:09
@frappe frappe deleted a comment from codecov bot Nov 29, 2021
Copy link
Collaborator

@sagarvora sagarvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barredterra @hrwX

I actually have a late request: as per convention, perhaps the number field should come before the date. Also worth noting that similar fields in Purchase Invoice and Sales Invoice have their own section with a column break between Number and Date.

@barredterra
Copy link
Collaborator

Thanks, @sagarvora. @hrwX please change accordingly.

auto-merge was automatically disabled November 30, 2021 14:28

Head branch was pushed to by a user without write access

@hrwX
Copy link
Contributor Author

hrwX commented Nov 30, 2021

@sagarvora @barredterra Updated the fields order.

@barredterra
Copy link
Collaborator

@hrwX what are your thoughts about the separate section?

@frappe frappe deleted a comment from codecov bot Nov 30, 2021
@hrwX
Copy link
Contributor Author

hrwX commented Nov 30, 2021

@hrwX what are your thoughts about the separate section?

  • Even if we see in Purchase Order, Order Confirmation and Date do not have their own sections, either we add a new section for both or we keep the fields in the first section of the form itself where its clearly visible.

barredterra
barredterra previously approved these changes Nov 30, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #28420 (f136755) into develop (fcb614d) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head f136755 differs from pull request most recent head ff402d0. Consider uploading reports for the commit ff402d0 to get more accurate results

@@             Coverage Diff             @@
##           develop   #28420      +/-   ##
===========================================
- Coverage    55.24%   55.21%   -0.04%     
===========================================
  Files         1122     1122              
  Lines        66828    66828              
===========================================
- Hits         36922    36900      -22     
- Misses       29906    29928      +22     
Impacted Files Coverage Δ
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 74.79% <0.00%> (-2.44%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.05% <0.00%> (-1.46%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 86.84% <0.00%> (-1.32%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/stock/stock_ledger.py 85.73% <0.00%> (-1.22%) ⬇️
erpnext/support/doctype/issue/issue.py 63.41% <0.00%> (-0.98%) ⬇️
erpnext/accounts/deferred_revenue.py 75.43% <0.00%> (-0.88%) ⬇️
... and 17 more

@sagarvora sagarvora added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Dec 11, 2021
@sagarvora
Copy link
Collaborator

I think people will get confused between transaction_date and quotation_date. Any reason why these should differ at all?

@sagarvora sagarvora changed the title feat(Supplier Quotation): quotation date and no in supplier quotation feat(Supplier Quotation): quotation number in supplier quotation Dec 11, 2021
@sagarvora
Copy link
Collaborator

@hrwX Can you please update the docs accordingly?

@sagarvora sagarvora changed the title feat(Supplier Quotation): quotation number in supplier quotation feat(buying): quotation number in supplier quotation Dec 11, 2021
@sagarvora sagarvora enabled auto-merge (squash) December 11, 2021 11:49
@sagarvora sagarvora merged commit 624481b into frappe:develop Dec 11, 2021
mergify bot pushed a commit that referenced this pull request Dec 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2021

backport version-13-hotfix

✅ Backports have been created

@barredterra
Copy link
Collaborator

I updated the docs

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants