-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(buying): quotation number in supplier quotation #28420
Conversation
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
@hrwX please mention the new fields in https://docs.erpnext.com/docs/v13/user/manual/en/buying/supplier-quotation |
Updated https://docs.erpnext.com/docs/v13/user/manual/en/buying/supplier-quotation#32-more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have a late request: as per convention, perhaps the number field should come before the date. Also worth noting that similar fields in Purchase Invoice and Sales Invoice have their own section with a column break between Number and Date.
Thanks, @sagarvora. @hrwX please change accordingly. |
Head branch was pushed to by a user without write access
@sagarvora @barredterra Updated the fields order. |
@hrwX what are your thoughts about the separate section? |
|
Codecov Report
@@ Coverage Diff @@
## develop #28420 +/- ##
===========================================
- Coverage 55.24% 55.21% -0.04%
===========================================
Files 1122 1122
Lines 66828 66828
===========================================
- Hits 36922 36900 -22
- Misses 29906 29928 +22
|
I think people will get confused between |
@hrwX Can you please update the docs accordingly? |
(cherry picked from commit 624481b)
✅ Backports have been created
|
I updated the docs |
Quotation Number
in Supplier Quotation similar toOrder Confirmation Number
in Purchase Order.Docs: https://docs.erpnext.com/docs/v13/user/manual/en/buying/supplier-quotation#32-more