feat: Make Depreciation Entry posting more flexible

[GangaManoj]

Problem

In order to post Depreciation Entries, you need to set 2 accounts:

1. Accumulated Depreciation Account
2. Depreciation Expense Account

However, this poses a problem for some customers in the European region. They prefer to use the same root node for both Income and Expense Accounts, which means that they're unable to set Depreciation Expense Accounts(which need to have Root Type = Expense). Consequently, they're unable to post Depreciation Entries(manually or otherwise).

Fix

• Change the filter for Depreciation Expense Account to allow the selection of Income accounts as well
• Post Depreciation Entries according to the root type of the Depreciation Expense Account

To Do:

• Rename Depreciation Expense Account

Testing Info

Case 1:

1. Create a new Asset Category

2. Set an Expense Account as the Depreciation Expense Account

3. Create a depreciable Asset belonging to that Asset Category, with Depreciation Starting Date set as a past date

4. After submission of the Asset doc, expand the Depreciation Schedule row whose Schedule Date has already passed and click on the Make Depreciation Entry button

   

5. Check the Journal Entry thus created and confirm that the Depreciation Expense Account was debited

Case 2:

1. Create a new Asset Category
2. Set an Income Account as the Depreciation Expense Account
3. Create a depreciable Asset belonging to that Asset Category, with Depreciation Starting Date set as a past date
4. After submission of the Asset doc, expand the Depreciation Schedule row whose Schedule Date has already passed and click on the Make Depreciation Entry button
5. Check the Journal Entry thus created and confirm that the Depreciation Expense Account was credited

no-docs

[codecov]

Codecov Report

Merging #28421 (56df646) into develop (87f2dcf) will decrease coverage by 0.14%.
The diff coverage is 92.30%.

@@             Coverage Diff             @@
##           develop   #28421      +/-   ##
===========================================
- Coverage    55.34%   55.19%   -0.15%     
===========================================
  Files         1119     1121       +2     
  Lines        66664    66760      +96     
===========================================
- Hits         36897    36851      -46     
- Misses       29767    29909     +142     

Impacted Files	Coverage Δ
erpnext/assets/doctype/asset/depreciation.py	84.93% <90.90%> (-2.48%)	⬇️
...xt/assets/doctype/asset_category/asset_category.py	87.30% <100.00%> (ø)
erpnext/utilities/product.py	14.70% <0.00%> (-35.30%)	⬇️
...wise_balance_history/batch_wise_balance_history.py	68.96% <0.00%> (-24.14%)	⬇️
erpnext/shopping_cart/product_info.py	30.30% <0.00%> (-21.22%)	⬇️
erpnext/regional/saudi_arabia/utils.py	23.75% <0.00%> (-11.81%)	⬇️
erpnext/stock/doctype/warehouse/warehouse.py	43.22% <0.00%> (-11.09%)	⬇️
erpnext/stock/doctype/bin/bin.py	87.27% <0.00%> (-5.04%)	⬇️
...ctype/woocommerce_settings/woocommerce_settings.py	80.00% <0.00%> (-4.00%)	⬇️
...eport/item_variant_details/item_variant_details.py	84.33% <0.00%> (-3.62%)	⬇️
... and 61 more

[nextchamp-saqib]

@Mergifyio backport version-13-hotfix

[mergify]

backport version-13-hotfix

✅ Backports have been created

• #28743 feat: Make Depreciation Entry posting more flexible (backport #28421) has been created for branch version-13-hotfix