Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with qrcode generation due to default print format name #28471

Merged

Conversation

nextchamp-saqib
Copy link
Member

If Default Print Format is in the Urdu language, the QR code generation fails with the below error

UnicodeEncodeError: 'latin-1' codec can't encode characters in position 57-62: ordinal not in range(256)

Fix:
Encode the URL parameters before creating a QRCode

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #28471 (ac27391) into develop (c0f06bc) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28471      +/-   ##
===========================================
+ Coverage    55.24%   55.31%   +0.06%     
===========================================
  Files         1119     1119              
  Lines        66553    66605      +52     
===========================================
+ Hits         36768    36842      +74     
+ Misses       29785    29763      -22     
Impacted Files Coverage Δ
erpnext/regional/saudi_arabia/utils.py 32.50% <0.00%> (-1.72%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 68.96% <0.00%> (-24.14%) ⬇️
...s/doctype/promotional_scheme/promotional_scheme.py 91.36% <0.00%> (-4.60%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.44% <0.00%> (-2.97%) ⬇️
erpnext/stock/stock_ledger.py 85.45% <0.00%> (-1.10%) ⬇️
erpnext/support/doctype/issue/issue.py 63.41% <0.00%> (-0.98%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.24% <0.00%> (-0.69%) ⬇️
erpnext/setup/doctype/item_group/item_group.py 48.40% <0.00%> (-0.67%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.83% <0.00%> (-0.44%) ⬇️
... and 29 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-pre-release

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Nov 22, 2021
…se/pr-28471

fix: bug with qrcode generation due to default print format name (backport #28471)
deepeshgarg007 added a commit that referenced this pull request Nov 22, 2021
…-28471

fix: bug with qrcode generation due to default print format name (backport #28471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants