Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KSA Invoice print format for multicurrency invoices #28489

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

deepeshgarg007
Copy link
Member

  1. Removed green color from the table header
  2. Show currency and amount in doc currency for multi-currency invoices

Before:
image

After:
Screenshot 2021-11-22 at 1 19 35 PM

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #28489 (73c5651) into develop (5f30104) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28489      +/-   ##
===========================================
+ Coverage    55.11%   55.31%   +0.20%     
===========================================
  Files         1119     1119              
  Lines        66575    66636      +61     
===========================================
+ Hits         36693    36863     +170     
+ Misses       29882    29773     -109     
Impacted Files Coverage Δ
erpnext/hooks.py 0.00% <ø> (ø)
erpnext/regional/saudi_arabia/utils.py 35.55% <ø> (+1.34%) ⬆️
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 75.92% <100.00%> (+0.27%) ⬆️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 92.40% <0.00%> (-2.54%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 89.53% <0.00%> (-1.83%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
...ng/report/work_order_summary/work_order_summary.py 73.00% <0.00%> (-1.23%) ⬇️
...ice_creation_tool/opening_invoice_creation_tool.py 60.13% <0.00%> (-0.70%) ⬇️
... and 32 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-pre-release

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-pre-release

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-pre-release

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant