Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Bin queries to qb #28522

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Nov 23, 2021

  • Move Bin.py queries to query builder.

@ankush
Copy link
Member Author

ankush commented Nov 23, 2021

wontfix sider issues, sider's suggestions are bad for QB type chaining code and makes it less readable.

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #28522 (b560bec) into develop (8b33358) will decrease coverage by 0.06%.
The diff coverage is 78.57%.

@@             Coverage Diff             @@
##           develop   #28522      +/-   ##
===========================================
- Coverage    55.33%   55.27%   -0.07%     
===========================================
  Files         1119     1119              
  Lines        66667    66676       +9     
===========================================
- Hits         36893    36856      -37     
- Misses       29774    29820      +46     
Impacted Files Coverage Δ
erpnext/stock/doctype/bin/bin.py 91.80% <78.57%> (-0.51%) ⬇️
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.44% <0.00%> (-2.97%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
erpnext/stock/reorder_item.py 75.21% <0.00%> (-1.71%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/stock/stock_ledger.py 84.93% <0.00%> (-1.09%) ⬇️
... and 16 more

@ankush ankush marked this pull request as ready for review November 26, 2021 09:09
@ankush ankush merged commit 69a17b9 into frappe:develop Nov 27, 2021
@ankush ankush deleted the bin_raw_queries branch November 27, 2021 14:37
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant