fix: misc minor Product Bundle fixes

[GangaManoj]

Problems Addressed:

1. On creating a Purchase Order from a Sales Order that has multiple Product Bundles in it, all the Product Bundles get added to the Purchase Order, even if they weren't selected.

Testing Info

1. Create a Sales Order
2. Add one or more Product Bundles to it
3. Create > Purchase Order
4. While selecting Items in the pop-up, don't select one or more of the Product Bundles

Expected Result: Only the child Items of the Product Bundle that was selected should show up in the Purchase Order.

2. When Calculate Product Bundle Price based on Child Items' Rates(under Selling Settings) is enabled, the price of Product Bundles in Quotations, Sales Orders, Delivery Notes etc should be calculated based on the rates entered in the Packed/Bundle Items table for its child Items. However, when there are multiple Product Bundles in the same Items list, this calculation is carried out incorrectly for every Product Bundle except the first.

Testing Info

1. Open Selling Settings
2. Enable Calculate Product Bundle Price based on Child Items' Rates
3. Create two or more Product Bundles
4. Create a Sales Order
5. Add two or more Product Bundles to the Items table
6. Save
7. Edit the rates for the child Items in the Packed Items table
8. Save

Expected Result: The prices of all the Product Bundles should be equal to the sum of the prices of its child Items.

3. On deleting Product Bundles from the Items table of any DocType that has a Packed/Bundle Items table(Sales Orders, Invoices, etc), the indices are not reset.

Images

Before:

Deleting the second row:

After:

Testing Info

1. Create 3 or more Product Bundles
2. Create a Sales Order
3. Add 3 or more Product Bundles to the Items table
4. Save
5. Delete any of the Product Bundles in the Items table(except the last)
6. Save
7. Refresh

Expected Result: The indices should be displayed in order.

4. If there are more than one Product Bundles in the Items table and any of them other than the last one are deleted, this happens till you refresh the page:

Testing Info

1. Create 3 or more Product Bundles
2. Create a Sales Order
3. Add 3 or more Product Bundles to the Items table
4. Save
5. Delete any of the Product Bundles in the Items table(except the last)
6. Save

[codecov]

Codecov Report

Merging #28533 (a1055d6) into develop (87f2dcf) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a1055d6 differs from pull request most recent head a473e1d. Consider uploading reports for the commit a473e1d to get more accurate results

@@             Coverage Diff             @@
##           develop   #28533      +/-   ##
===========================================
- Coverage    55.34%   55.32%   -0.03%     
===========================================
  Files         1119     1119              
  Lines        66664    66668       +4     
===========================================
- Hits         36897    36881      -16     
- Misses       29767    29787      +20     

Impacted Files	Coverage Δ
erpnext/selling/doctype/sales_order/sales_order.py	77.50% <ø> (-0.39%)	⬇️
erpnext/stock/doctype/packed_item/packed_item.py	84.34% <100.00%> (+8.67%)	⬆️
erpnext/utilities/product.py	14.70% <0.00%> (-35.30%)	⬇️
erpnext/shopping_cart/product_info.py	30.30% <0.00%> (-21.22%)	⬇️
erpnext/education/doctype/student/student.py	73.68% <0.00%> (-3.16%)	⬇️
...ion/doctype/course_enrollment/course_enrollment.py	44.00% <0.00%> (-2.00%)	⬇️
...e/shopping_cart_settings/shopping_cart_settings.py	65.38% <0.00%> (-1.93%)	⬇️
erpnext/shopping_cart/product_query.py	61.19% <0.00%> (-1.50%)	⬇️
erpnext/portal/utils.py	28.98% <0.00%> (-1.45%)	⬇️
.../report/stock_projected_qty/stock_projected_qty.py	88.15% <0.00%> (-1.32%)	⬇️
... and 15 more

[deepeshgarg007]

@Mergifyio backport version-13-hotfix

[deepeshgarg007]

@Mergifyio backport version-13-pre-release

[mergify]

backport version-13-hotfix

✅ Backports have been created

• #28681 fix: misc minor Product Bundle fixes (backport #28533) has been created for branch version-13-hotfix

[mergify]

backport version-13-pre-release

✅ Backports have been created

• #28682 fix: misc minor Product Bundle fixes (backport #28533) has been created for branch version-13-pre-release