Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot load company form #28535

Merged

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Nov 24, 2021

Problem:
The default currency field is set as read-only if any transaction exists against the company.
If the query to check_if_transactions_exist takes more than 300 secs (timeout limit) the company form cannot be loaded.

Fix:
Check for transactions later once the form has been loaded.

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #28535 (d938d70) into develop (624e58d) will increase coverage by 0.02%.
The diff coverage is 36.66%.

@@             Coverage Diff             @@
##           develop   #28535      +/-   ##
===========================================
+ Coverage    55.31%   55.34%   +0.02%     
===========================================
  Files         1119     1119              
  Lines        66610    66635      +25     
===========================================
+ Hits         36846    36876      +30     
+ Misses       29764    29759       -5     
Impacted Files Coverage Δ
...pnext/accounts/report/gross_profit/gross_profit.py 0.00% <0.00%> (ø)
...nts/doctype/accounts_settings/accounts_settings.py 100.00% <100.00%> (ø)
erpnext/accounts/doctype/party_link/party_link.py 85.71% <100.00%> (+8.79%) ⬆️
...e/period_closing_voucher/period_closing_voucher.py 89.70% <100.00%> (+1.64%) ⬆️
erpnext/setup/doctype/company/company.py 71.94% <100.00%> (+0.23%) ⬆️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.44% <0.00%> (-2.97%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-1.71%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.24% <0.00%> (-1.46%) ⬇️
... and 28 more

@nextchamp-saqib
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@nextchamp-saqib nextchamp-saqib merged commit 01d8b85 into frappe:develop Dec 1, 2021
mergify bot pushed a commit that referenced this pull request Dec 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2021

backport version-13-hotfix

✅ Backports have been created

conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant