Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Paid invoices showing in AR/AP report #28627

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Nov 29, 2021

Paid Multicurrency Invoices still showing up in AR/AP report

Steps to test:

  1. Make a multi-currency sales invoice from INR to USD at an exchange rate of 70

Screenshot 2021-12-02 at 6 40 30 PM

  1. Make a standalone payment against the same customer at an exchange rate of 65

Screenshot 2021-12-02 at 6 44 04 PM

  1. Reconcile this payment against the Invoice using the payment reconciliation tool

Screenshot 2021-12-02 at 6 44 42 PM

The status Of the invoice will be changed to paid but it is still visible in the Accounts Payable Report if you'll check using the inline data table filters

Screenshot 2021-12-02 at 7 03 26 PM

Solution: Check for outstanding amount in both company and party currency as well

@deepeshgarg007 deepeshgarg007 changed the title fix: Paid showing in AR/AP report fix: Paid invoices showing in AR/AP report Nov 29, 2021
@deepeshgarg007 deepeshgarg007 merged commit 8309cbe into frappe:version-13-hotfix Dec 2, 2021
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport develop

@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2021

backport develop

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Dec 3, 2021
fix: Paid invoices showing in AR/AP report (backport #28627)
@aakvatech
Copy link
Contributor

This problem will be come back from Journals as well that are affecting party. It is because of a need to have adjustment journal to adjust the exchange gain and loss balance that can occur due to party paying in different currency than the invoiced currency and there is an exchange rate difference resulting into a decimal value.

Not sure of the solution but will create separate issue so it can be handled in next sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants