Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ageing in AR/AP report for advances #28748

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Dec 6, 2021

When ageing is viewed by due date no ageing is shown for advances received via Journal Entry or payment as they don't have any Due Date.

This leads to a mismatch in the outstanding amount and the amount when the ageing amount in all the ageing columns is added.

This PR considers the Jounral Entry's and Payment Entry's posting date as the due date to show the ageing based on due date for such entries

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #28748 (3dabac1) into develop (0b1808e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #28748      +/-   ##
===========================================
- Coverage    55.21%   55.14%   -0.07%     
===========================================
  Files         1121     1122       +1     
  Lines        66785    66772      -13     
===========================================
- Hits         36872    36820      -52     
- Misses       29913    29952      +39     
Impacted Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 68.80% <0.00%> (ø)
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 69.23% <0.00%> (-25.00%) ⬇️
erpnext/stock/doctype/warehouse/warehouse.py 43.22% <0.00%> (-11.09%) ⬇️
erpnext/stock/doctype/bin/bin.py 87.27% <0.00%> (-4.54%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 89.05% <0.00%> (-3.65%) ⬇️
erpnext/education/doctype/student/student.py 73.68% <0.00%> (-3.16%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-2.98%) ⬇️
erpnext/stock/utils.py 65.27% <0.00%> (-2.10%) ⬇️
...ion/doctype/course_enrollment/course_enrollment.py 44.00% <0.00%> (-2.00%) ⬇️
... and 33 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2021

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Dec 12, 2021
…-28748

fix: Ageing in AR/AP report for advances (backport #28748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant