fix: KSA QR field rename patch #28832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28832 +/- ##
===========================================
- Coverage 55.28% 55.25% -0.03%
===========================================
Files 1122 1122
Lines 66828 66828
===========================================
- Hits 36943 36928 -15
- Misses 29885 29900 +15
|
rtdany10
reviewed
Dec 12, 2021
| @@ -12,5 +13,20 @@ def execute(): | |||
|
|
|||
| if frappe.db.exists('DocType', 'Sales Invoice'): | |||
| frappe.reload_doc('accounts', 'doctype', 'sales_invoice', force=True) | |||
|
|
|||
| # rename_field method assumes that the field already exists or the doc is synced | |||
| if not frappe.db.has_column('Sales Invoice', 'ksa_einv_qr'): | |||
There was a problem hiding this comment.
Shouldn't https://github.com/frappe/erpnext/blob/develop/erpnext/regional/saudi_arabia/utils.py#L19-L30 be enough? 🤔
It checks if the field is present, if not, creates, before sales invoice is submitted.
There was a problem hiding this comment.
Then there is no point of the patch then, the patch will get executed before the field is created and no data will me moved from the old field in the invoices
|
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
|
@Mergifyio backport version-13-pre-release |
✅ Backports have been created
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Dec 14, 2021
…-28832 fix: KSA QR field rename patch (backport #28832)
deepeshgarg007
added a commit
that referenced
this pull request
Dec 14, 2021
…se/pr-28832 fix: KSA QR field rename patch (backport #28832)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in #28776
The data from old field was not migrated to the new field as it didn't exist in the first place