Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Employee Exit Summary #28888

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

ruchamahabal
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #28888 (aea2a2a) into develop (96ef88d) will increase coverage by 10.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #28888       +/-   ##
============================================
+ Coverage    45.11%   55.55%   +10.44%     
============================================
  Files         1125     1125               
  Lines        66985    66985               
============================================
+ Hits         30217    37216     +6999     
+ Misses       36768    29769     -6999     
Impacted Files Coverage Δ
erpnext/hr/report/employee_exits/employee_exits.py 84.28% <ø> (+84.28%) ⬆️
...ctype/woocommerce_settings/woocommerce_settings.py 80.00% <0.00%> (-4.00%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 68.16% <0.00%> (-0.65%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.37% <0.00%> (+0.26%) ⬆️
erpnext/setup/doctype/company/company.py 71.94% <0.00%> (+0.33%) ⬆️
erpnext/accounts/general_ledger.py 93.98% <0.00%> (+0.54%) ⬆️
erpnext/accounts/utils.py 58.68% <0.00%> (+0.54%) ⬆️
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 75.92% <0.00%> (+0.74%) ⬆️
...xt/accounts/doctype/payment_entry/payment_entry.py 69.25% <0.00%> (+0.74%) ⬆️
... and 218 more

@ruchamahabal ruchamahabal force-pushed the employee-exit-test branch 2 times, most recently from 4c4c602 to 96691c4 Compare December 14, 2021 13:41
@ruchamahabal ruchamahabal added the Skip Manual Testing The changes in this PR does not require manual testing label Dec 14, 2021
@ruchamahabal ruchamahabal changed the title fix: sorting order in Employee Exits report query fix(test): Employee Exit Summary Dec 14, 2021
@ruchamahabal
Copy link
Member Author

ruchamahabal commented Dec 14, 2021

Patch test failure is unrelated (framework). Not fixing query builder sider issues, not helpful.

@ruchamahabal ruchamahabal marked this pull request as ready for review December 14, 2021 16:33
@ruchamahabal ruchamahabal merged commit a481a7c into frappe:develop Dec 14, 2021
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
conncampbell pushed a commit to conncampbell/erpnext that referenced this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Manual Testing The changes in this PR does not require manual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant