Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert asynchronous field update to synchronous #28906

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

mro-admin
Copy link

@mro-admin mro-admin commented Dec 15, 2021

Issue: When using the Item Alternate button. The field original_item for each item doesn't get properly updated.

To reproduce

  1. Create a Stock Entry for a work order with more than a couple of required items.
  2. Create Item Alternative for each Item
  3. Use the "Item Alternate" button to replace all required items with Item Alternative
  4. Open console and print the object cur_frm.doc.items
  5. Notice that some items with item alternative doesn't have the original_item field filled out
  6. Even after Submission the original_item field isn't filled out

Fix: Change field updates to synchronous

@ankush
Copy link
Member

ankush commented Dec 17, 2021

@Mergifyio copy develop

@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2021

copy develop

✅ Pull request copies have been created

@ankush ankush merged commit c5931e4 into frappe:version-13-hotfix Dec 17, 2021
@ankush
Copy link
Member

ankush commented Dec 17, 2021

thanks a lot for this fix @mro-admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants