-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Validation in POS for item batch no stock quantity #28907
Merged
nextchamp-saqib
merged 8 commits into
frappe:develop
from
nemesis189:pos-batch-no-stock-validation
Jan 3, 2022
Merged
fix: Validation in POS for item batch no stock quantity #28907
nextchamp-saqib
merged 8 commits into
frappe:develop
from
nemesis189:pos-batch-no-stock-validation
Jan 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesis189
requested review from
ankush,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
December 15, 2021 17:38
Codecov Report
@@ Coverage Diff @@
## develop #28907 +/- ##
===========================================
+ Coverage 55.72% 55.77% +0.05%
===========================================
Files 1131 1131
Lines 67550 67574 +24
===========================================
+ Hits 37639 37690 +51
+ Misses 29911 29884 -27
|
nextchamp-saqib
approved these changes
Jan 3, 2022
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
nextchamp-saqib
added a commit
that referenced
this pull request
Jan 3, 2022
…-28907 fix: Validation in POS for item batch no stock quantity (backport #28907)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Issue walkthrough(Steps):
Solution:
if available_qty - pos_reserved_qty - current_needed_qty < 0 then throw error