-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multicurrency invoices using subscription #28916
Merged
deepeshgarg007
merged 2 commits into
frappe:develop
from
deepeshgarg007:multicurrency_subscription
Dec 17, 2021
Merged
fix: Multicurrency invoices using subscription #28916
deepeshgarg007
merged 2 commits into
frappe:develop
from
deepeshgarg007:multicurrency_subscription
Dec 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28916 +/- ##
========================================
Coverage 55.57% 55.58%
========================================
Files 1126 1126
Lines 67199 67201 +2
========================================
+ Hits 37349 37355 +6
+ Misses 29850 29846 -4
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Dec 17, 2021
…-28916 fix: Multicurrency invoices using subscription (backport #28916)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user gets the following error on trying to create an invoice using subscription against a party having billing currency other than the company currency
Sets to test the pull request
Create a subscription plan in party currency
Create a backdated subscription as per the following details
Click on the fetch subscription updates button on the top right and see if the invoice gets generated successfully