Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multicurrency invoices using subscription #28916

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Dec 16, 2021

The user gets the following error on trying to create an invoice using subscription against a party having billing currency other than the company currency

image

Sets to test the pull request

  1. Create a customer with billing currency other than company currency, Eg USD if company currency is INR

Screenshot 2021-12-17 at 12 18 05 PM

  1. Create a subscription plan in party currency
    image

  2. Create a backdated subscription as per the following details
    image

  3. Click on the fetch subscription updates button on the top right and see if the invoice gets generated successfully
    image

@deepeshgarg007 deepeshgarg007 added the needs-tests This PR needs automated unit-tests. label Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #28916 (6ab7530) into develop (2be62c2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #28916   +/-   ##
========================================
  Coverage    55.57%   55.58%           
========================================
  Files         1126     1126           
  Lines        67199    67201    +2     
========================================
+ Hits         37349    37355    +6     
+ Misses       29850    29846    -4     
Impacted Files Coverage Δ
...next/accounts/doctype/subscription/subscription.py 81.84% <100.00%> (+0.10%) ⬆️
...work_order_stock_report/work_order_stock_report.py 50.00% <0.00%> (-50.00%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.93% <0.00%> (-2.74%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 86.84% <0.00%> (-2.64%) ⬇️
...eport/production_analytics/production_analytics.py 69.51% <0.00%> (-1.22%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (ø)
...ext/payroll/doctype/payroll_entry/payroll_entry.py 70.79% <0.00%> (ø)
...stock/doctype/purchase_receipt/purchase_receipt.py 90.64% <0.00%> (ø)
erpnext/stock/report/stock_ageing/stock_ageing.py 91.24% <0.00%> (+0.72%) ⬆️
erpnext/stock/reorder_item.py 76.06% <0.00%> (+0.85%) ⬆️
... and 7 more

@deepeshgarg007 deepeshgarg007 removed the needs-tests This PR needs automated unit-tests. label Dec 16, 2021
@deepeshgarg007 deepeshgarg007 merged commit 238403d into frappe:develop Dec 17, 2021
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2021

backport version-13-hotfix

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant