Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move patches to post migration #28940

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Dec 17, 2021

depends on frappe/frappe#15351

changes:

  • move some v14 patches to post-migration that can run in post-migration.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #28940 (7e857fc) into develop (b139ee1) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 7e857fc differs from pull request most recent head 3986d50. Consider uploading reports for the commit 3986d50 to get more accurate results

@@             Coverage Diff             @@
##           develop   #28940      +/-   ##
===========================================
- Coverage    55.62%   55.61%   -0.01%     
===========================================
  Files         1127     1127              
  Lines        67241    67241              
===========================================
- Hits         37401    37395       -6     
- Misses       29840    29846       +6     
Impacted Files Coverage Δ
.../manufacturing/report/bom_explorer/bom_explorer.py 94.44% <0.00%> (-5.56%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
erpnext/stock/reorder_item.py 76.06% <0.00%> (-1.71%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.06% <0.00%> (-1.57%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
erpnext/support/doctype/issue/issue.py 64.03% <0.00%> (-0.99%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.84% <0.00%> (-0.56%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 68.37% <0.00%> (-0.43%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 77.58% <0.00%> (-0.39%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.37% <0.00%> (-0.27%) ⬇️
... and 6 more

@ankush ankush closed this Dec 20, 2021
@ankush ankush reopened this Jan 3, 2022
@ankush ankush closed this Jan 3, 2022
@ankush ankush reopened this Jan 26, 2022
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 26, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jan 26, 2022
@ankush ankush added the Skip Manual Testing The changes in this PR does not require manual testing label Jan 26, 2022
@ankush ankush marked this pull request as ready for review January 26, 2022 07:10
@ankush ankush merged commit 7eab945 into frappe:develop Jan 26, 2022
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant