test: test failure due to rounding

[rtdany10]

FAIL  test_average_ratings_on_feedback_submission_and_cancellation
(erpnext.hr.doctype.interview_feedback.test_interview_feedback.TestInterviewFeedback)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/frappe-bench/apps/erpnext/erpnext/hr/doctype/interview_feedback/
        test_interview_feedback.py", line 62, in test_average_ratings_on_feedback_submission_and_cancellation
    self.assertEqual(avg_on_interview_detail, round(feedback_1.average_rating))
AssertionError: 3.5 != 4

Rounding produces different result in case of averages with decimal and hence the assertEqual fails.

[rtdany10]

Issue arises only if the average has decimal. Since random function generates ratings, the average might or might not have decimal. I assume, so far, the test passed cause the average didn't have a decimal and hence the round function really didn't have any effect? 😕

https://github.com/frappe/erpnext/blob/develop/erpnext/hr/doctype/interview_feedback/test_interview_feedback.py#L95-L101

P.S Tests all passing 😄

[rtdany10]

@Mergifyio backport version-13-hotfix

[mergify]

backport version-13-hotfix

🟠 Waiting for conditions to match

• merged [:pushpin: backport requirement]

[ankush]

this is failing because of frappe/frappe#15203

Change in code is required, instead of fixing test 😄

[rtdany10]

Change in code is required, instead of fixing test

Skeptical of that since the code assigns the value as it should, without rounding (?) 😕

erpnext/erpnext/hr/doctype/interview_feedback/interview_feedback.py

Line 70 in e85da7a

entry.average_rating = self.average_rating

[rtdany10]

My bad. Ratings are divided by number of stars and stored in db now.
So, yes, the code requires change. Shall I try fix it on this PR itself?

@ankush

[ankush]

Let's leave this for now, we will soon start allowing half-star ratings so then rounding won't make much sense.

ref: frappe/frappe#15203 (comment)

[mergify]

backport version-13-hotfix

✅ Backports have been created

• #28946 fix: test failure due to rounding (backport #28945) has been created for branch version-13-hotfix